Page MenuHomePhabricator

[lib] add reply/replies back to sidebar inline engagement
ClosedPublic

Authored by ginsu on Jun 26 2023, 3:25 PM.
Tags
None
Referenced Files
F3388074: D8317.diff
Fri, Nov 29, 12:37 PM
Unknown Object (File)
Wed, Nov 27, 6:14 PM
Unknown Object (File)
Sat, Nov 23, 2:22 PM
Unknown Object (File)
Mon, Nov 18, 11:40 AM
Unknown Object (File)
Fri, Nov 1, 2:24 PM
Unknown Object (File)
Fri, Nov 1, 2:24 PM
Unknown Object (File)
Fri, Nov 1, 2:24 PM
Unknown Object (File)
Fri, Nov 1, 2:23 PM
Subscribers

Details

Summary

Based off this comment in Linear, we want to add the word reply/replies in order to differentiate the thread replies from the reactions

Linear Task: https://linear.app/comm/issue/ENG-3103/update-inlineengagement-for-native

Test Plan

Please see the screenshots below:

Screenshot 2023-06-24 at 2.06.39 PM.png (1×1 px, 818 KB)

Screenshot 2023-06-24 at 2.05.37 PM.png (1×1 px, 817 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu requested review of this revision.Jun 26 2023, 3:43 PM
This revision is now accepted and ready to land.Jun 27 2023, 1:17 AM
ginsu retitled this revision from [native] add reply/replies back to sidebar inline engagement to [lib] add reply/replies back to sidebar inline engagement.Jul 26 2023, 10:56 AM