Page MenuHomePhabricator
Differential D8576

[native] make reactions prop for InlineEngagement requried
ClosedPublic
Actions

Authored by ginsu on Jul 19 2023, 2:38 PM.
Tags
None
Referenced Files
F3388325: D8576.diff
Fri, Nov 29, 1:44 PM
Unknown Object (File)
Sat, Nov 23, 12:52 PM
Unknown Object (File)
Sat, Nov 23, 12:52 PM
Unknown Object (File)
Sat, Nov 23, 12:52 PM
Unknown Object (File)
Oct 28 2024, 7:43 AM
Unknown Object (File)
Oct 13 2024, 2:13 PM
Unknown Object (File)
Sep 28 2024, 8:57 AM
Unknown Object (File)
Sep 28 2024, 8:57 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried
Summary

In the very next diff we will introduce sending a reaction by pressing on a pill. To prepare for this we need to make reactions prop required so we can use the sendReaction hook

Depends on D8575

Test Plan

flow and confirmed that the InlineEngagement still looks and works as expected for both composed messages and robotext messages

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 19 2023, 2:38 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2023, 2:38 PM
ginsu added inline comments.Jul 19 2023, 2:52 PM
native/chat/inline-engagement.react.js
41–42 ↗(On Diff #28869)

I just moved this below sidebarInfo so the ordering matched the prop type above

ginsu edited the summary of this revision. (Show Details)Jul 19 2023, 2:53 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8575: [native] add spacing in between each reaction pill.
ginsu edited the summary of this revision. (Show Details)Jul 19 2023, 2:55 PM
ginsu added a child revision: D8578: [native] introduce functionality to send a reaction by pressing on the reaction pill..Jul 19 2023, 3:31 PM
Harbormaster completed remote builds in B21069: Diff 28869.Jul 19 2023, 3:35 PM
ginsu requested review of this revision.Jul 19 2023, 3:35 PM
kamil accepted this revision.Jul 21 2023, 2:55 AM
This revision is now accepted and ready to land.Jul 21 2023, 2:55 AM
ginsu updated this revision to Diff 28952.Jul 21 2023, 11:48 AM

rebase

Harbormaster completed remote builds in B21130: Diff 28952.Jul 21 2023, 12:05 PM
ginsu updated this revision to Diff 29306.Jul 31 2023, 11:37 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM
Closed by commit rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried.
Harbormaster completed remote builds in B21394: Diff 29306.Jul 31 2023, 1:55 PM

Revision Contents
Changeset List

PathSize
native/
chat/
11 lines

Diff 28952

View Options

native/chat/inline-engagement.react.js

Loading...