HomePhabricator
Diffusion Comm 3fa1fafd962e

[yarn] Lift `.npmrc` up from `keyserver` to root of repo

Description

[yarn] Lift .npmrc up from keyserver to root of repo

Summary:
Addresses the issue with yarn upgrade-interactive documented by @benschac in ENG-1063: https://linear.app/comm/issue/ENG-1063/yarn-upgrade-interactive-functionality-errors

Basically, found that yarn upgrade-interactive failed in every yarn workspace except for keyserver. Was wondering what might be different, and remembered that we had to add an entry to keyserver/.npmrc in order for things to work there (https://phabricator.ashoat.com/D2966).

Tried moving .npmrc to the root of the repo and yarn upgrade-interactive worked fine without errors. I don't have much context on why we needed the .npmrc in the first place, but remember there was some weirdness with matrix/gitlab/etc... (would be good to get @marcinwasowicz's perspective here).

Test Plan:

  1. Run yarn upgrade-interactive in the root of the repo.
  2. See if the yarn upgrade-interactive TUI shows up without displaying the "Can't find blah..." error message.

Did not actually try upgrading any packages with this interface. Will end up testing that implicitly the next time I upgrade a package (usually just modify package.json, but can use this approach just to make sure it works)

Reviewers: def-au1t, ashoat, benschac

Reviewed By: ashoat

Subscribers: palys-swm, Adrian, karol-bisztyga, yayabosh, benschac, marcinwasowicz

Differential Revision: https://phabricator.ashoat.com/D3888

Details

Provenance
atulAuthored on May 2 2022, 10:33 AM
Reviewer
ashoat
Differential Revision
D3888: [yarn] Lift `.npmrc` up from `keyserver` to root of repo
Parents
rCOMMb28027302a74: [web] Remove extraneous `border-radius` property in `modal.css: modalContainer`
Branches
Unknown
Tags
Unknown