HomePhabricator
Diffusion Comm 70287307d2bb

[native] Increase size of camera and gallery icons

Tags
None
Referenced Files
F172393: ENG-1723 After.png
Sep 28 2022, 3:53 AM
File Not Attached
F172392: ENG-1723 Before.png
Sep 28 2022, 3:53 AM
File Not Attached
Subscribers
None

Description

[native] Increase size of camera and gallery icons

Summary:
Increased the size of the icons in chat (camera and gallery icons), and added some more padding
between the icons and the chat input to address the issue of accidental clicks. This addresses ENG-1723:
https://linear.app/comm/issue/ENG-1723/take-photo-photo-gallery-icons-should-be-bigger

Test Plan:
Compared the icon sizes on both Android and iOS before and after making these changes, and the
icons are visually larger and easier to click as they are separated a little more. Since there is no official
design for this yet, reviewer feedback can decide if it's visually and functionally better.

Before:

ENG-1723 Before.png (1×1 px, 938 KB)

After:

ENG-1723 After.png (1×1 px, 882 KB)

Additionally, I tested the tap radiuses of each component and it's much easier to interact with the respective icons. Similarly, increasing the size of these doesn't cause any undesired behavior with the expando button and typing a message.

Reviewers: atul, abosh, ashoat

Reviewed By: atul, ashoat

Subscribers: ginsu, ashoat, tomek

Differential Revision: https://phab.comm.dev/D5169

Details

Provenance
rohanAuthored on Sep 19 2022, 9:27 AM
Reviewer
atul
Differential Revision
D5169: [native] Increase size of camera and gallery icons
Parents
rCOMM2b34f355dd81: Replace throw with log and early return when trying to update thread that does…
Branches
Unknown
Tags
Unknown