HomePhabricator
Diffusion Comm 8f351e2303cb

[commtest] Make service endpoints configurable

Description

[commtest] Make service endpoints configurable

Summary:
Attempt to clean up mess with service addresses in commtest. Gives ability to configure endpoints of tested services, and thus running the tests from within docker network.

Introduced a single source of truth with hardcoded defaults, and two ways of overriding them:

  1. Keeping localhost, while overriding port with COMM_SERVICES_PORT_* env variable - this maintains current behavior for blob and backup
  2. overriding the whole endpoint using *_SERVICE_URL for HTTP services, *_GRPC_ENDPOINT for gRPC services, and *_WS_ENDPOINT for websocket

Depends on D9509

Test Plan:

  • Ran commtest for all services the usual way, ensured the tests are passing (or at least not failing due to network error)
  • Changed ports in .env file and ensured the tests are reaching services on new ports
  • Overriden the endpoint correctly (one way is to use staging service address) and ensured the tests are addressing the correct service

Reviewers: varun, michal, kamil, jon

Reviewed By: michal, kamil

Subscribers: ashoat, tomek, wyilio

Differential Revision: https://phab.comm.dev/D9510

Details

Provenance
bartekAuthored on Oct 17 2023, 4:31 AM
Reviewer
michal
Differential Revision
D9510: [commtest] Make service endpoints configurable
Parents
rCOMM8d4fa94043bb: [blob] Add CLI option to enable auto-deletion
Branches
Unknown
Tags
Unknown