Paths

Table of Contentst

Differential D9510

[commtest] Make service endpoints configurable
ClosedPublic
Actions

Authored by bartek on Oct 17 2023, 5:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 25, 5:01 AM

	Unknown Object (File)
	Tue, Jun 25, 5:01 AM

	Unknown Object (File)
	Tue, Jun 25, 5:01 AM

	Unknown Object (File)
	Tue, Jun 25, 5:00 AM

	Unknown Object (File)
	Tue, Jun 25, 4:53 AM

	Unknown Object (File)
	Sat, Jun 15, 7:07 PM

	Unknown Object (File)
	Fri, Jun 14, 3:18 PM

	Unknown Object (File)
	Fri, Jun 14, 2:13 AM

View All 78 Files

Subscribers

Details

Reviewers

varun
michal
kamil
• jon

Commits

rCOMM8f351e2303cb: [commtest] Make service endpoints configurable

Summary

Attempt to clean up mess with service addresses in commtest. Gives ability to configure endpoints of tested services, and thus running the tests from within docker network.

Introduced a single source of truth with hardcoded defaults, and two ways of overriding them:

Keeping localhost, while overriding port with COMM_SERVICES_PORT_* env variable - this maintains current behavior for blob and backup
overriding the whole endpoint using *_SERVICE_URL for HTTP services, *_GRPC_ENDPOINT for gRPC services, and *_WS_ENDPOINT for websocket

Depends on D9509

Test Plan

Ran commtest for all services the usual way, ensured the tests are passing (or at least not failing due to network error)
Changed ports in .env file and ensured the tests are reaching services on new ports
Overriden the endpoint correctly (one way is to use staging service address) and ensured the tests are addressing the correct service

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 17 2023, 5:47 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 17 2023, 5:47 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

bartek added a child revision: D9511: [commtest] Add dockerfile and entrypoint script.Oct 17 2023, 5:50 AM

I'll need to rebase it on @varun's stack once it's landed

services/commtest/tests/blob_integration_test.rs
49 ↗	(On Diff #32076)	This and many below changes are just clippy fixes

Harbormaster completed remote builds in B23285: Diff 32076.Oct 17 2023, 6:05 AM

Nice

services/commtest/src/identity/device.rs
64 ↗	(On Diff #32076)	Can this comment be removed now?

This revision is now accepted and ready to land.Oct 18 2023, 3:22 AM

Massive improvement 👏

services/commtest/src/service_addr.rs
14 ↗	(On Diff #32076)	shouldn't this be `http`?

bartek added inline comments.Oct 18 2023, 7:47 AM

services/commtest/src/service_addr.rs
14 ↗	(On Diff #32076)	of course it should! I'm surprised that it worked despite being wrong 😅

Rebase on latest changes. Fix scheme, reomve todo comment.

Harbormaster completed remote builds in B23346: Diff 32175.Oct 19 2023, 1:39 AM

Closed by commit rCOMM8f351e2303cb: [commtest] Make service endpoints configurable (authored by bartek). · Explain WhyOct 20 2023, 9:22 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8f351e2303cb: [commtest] Make service endpoints configurable.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

4 lines

1 line

service_addr.rs

87 lines

tunnelbroker/

3 lines

tests/

backup_integration_test.rs

11 lines

backup_performance_test.rs

11 lines

blob_integration_test.rs

28 lines

blob_performance_test.rs

20 lines

grpc_client_test.rs

10 lines

identity_access_tokens_tests.rs

9 lines

identity_keyserver_tests.rs

6 lines

identity_one_time_key_tests.rs

3 lines

identity_prekey_tests.rs

3 lines

identity_tunnelbroker_tests.rs

8 lines

tunnelbroker_integration_tests.rs

5 lines

tunnelbroker_persist_tests.rs

5 lines

Diff 32279

services/commtest/src/identity/device.rs

Loading...

services/commtest/src/lib.rs

Loading...

services/commtest/src/service_addr.rs

Loading...

services/commtest/src/tunnelbroker/socket.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...

services/commtest/tests/blob_integration_test.rs

Loading...

services/commtest/tests/blob_performance_test.rs

Loading...

services/commtest/tests/grpc_client_test.rs

Loading...

services/commtest/tests/identity_access_tokens_tests.rs

Loading...

services/commtest/tests/identity_keyserver_tests.rs

Loading...

services/commtest/tests/identity_one_time_key_tests.rs

Loading...

services/commtest/tests/identity_prekey_tests.rs

Loading...

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...

services/commtest/tests/tunnelbroker_persist_tests.rs

Loading...