Page MenuHomePhabricator

[blob] Add CLI option to enable auto-deletion
ClosedPublic

Authored by bartek on Oct 17 2023, 5:41 AM.
Tags
None
Referenced Files
F3367121: D9509.id32075.diff
Mon, Nov 25, 1:47 PM
Unknown Object (File)
Sat, Nov 16, 9:17 AM
Unknown Object (File)
Sun, Oct 27, 4:25 PM
Unknown Object (File)
Sep 28 2024, 12:24 AM
Unknown Object (File)
Sep 28 2024, 12:24 AM
Unknown Object (File)
Sep 28 2024, 12:23 AM
Unknown Object (File)
Sep 28 2024, 12:18 AM
Unknown Object (File)
Sep 20 2024, 8:09 AM
Subscribers

Details

Summary

Since introduction of blob cleanup, specifically D9413, blob integration tests are broken (deletion part)
Until we have ENG-4439 implemented,
we need to have option to restore pre-cleanup behavior. This diff adds a CLI option for that.

Depends on D9508

Test Plan

Tested with aws-cli (awslocal dynamodb scan --table-name blob-service-blobs)

  • With the --instant-delete flag set, calling DELETE endpoint on last holder removes blob and holder rows from DDB
  • Without the flag, the blob item DB row is marked as unchecked.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable