Paths

Table of Contentst

Differential D9509

[blob] Add CLI option to enable auto-deletion
ClosedPublic
Actions

Authored by bartek on Oct 17 2023, 5:41 AM.

Tags

None

Referenced Files

	F2831561: D9509.id32277.diff
	Sat, Sep 28, 12:24 AM

	F2831560: D9509.id32075.diff
	Sat, Sep 28, 12:24 AM

	F2831534: D9509.id.diff
	Sat, Sep 28, 12:23 AM

	F2831512: D9509.diff
	Sat, Sep 28, 12:18 AM

	Unknown Object (File)
	Fri, Sep 20, 8:09 AM

	Unknown Object (File)
	Wed, Sep 18, 8:05 AM

	Unknown Object (File)
	Aug 27 2024, 1:40 PM

	Unknown Object (File)
	Aug 27 2024, 1:32 PM

View All 83 Files

Subscribers

Details

Reviewers

michal
varun
• jon

Commits

rCOMM8d4fa94043bb: [blob] Add CLI option to enable auto-deletion

Summary

Since introduction of blob cleanup, specifically D9413, blob integration tests are broken (deletion part)
Until we have ENG-4439 implemented,
we need to have option to restore pre-cleanup behavior. This diff adds a CLI option for that.

Depends on D9508

Test Plan

Tested with aws-cli (awslocal dynamodb scan --table-name blob-service-blobs)

With the --instant-delete flag set, calling DELETE endpoint on last holder removes blob and holder rows from DDB
Without the flag, the blob item DB row is marked as unchecked.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 17 2023, 5:41 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 17 2023, 5:41 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

bartek added a child revision: D9510: [commtest] Make service endpoints configurable.Oct 17 2023, 5:47 AM

bartek mentioned this in D9512: [services] Add docker-compose overrides for tests.Oct 17 2023, 5:57 AM

Harbormaster completed remote builds in B23284: Diff 32075.Oct 17 2023, 5:59 AM

bartek published this revision for review.Oct 17 2023, 6:01 AM

bartek added inline comments.

services/blob/src/main.rs
42 ↗	(On Diff #32075)	leftover

michal accepted this revision.Oct 18 2023, 3:14 AM

This revision is now accepted and ready to land.Oct 18 2023, 3:14 AM

Closed by commit rCOMM8d4fa94043bb: [blob] Add CLI option to enable auto-deletion (authored by bartek). · Explain WhyOct 20 2023, 9:22 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8d4fa94043bb: [blob] Add CLI option to enable auto-deletion.

bartek mentioned this in rCOMMf8477adb619e: [services] Add docker-compose overrides for tests.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

6 lines

11 lines

Diff 32277

services/blob/src/config.rs

Loading...

services/blob/src/main.rs

Loading...