HomePhabricator
Diffusion Comm cde14a0ab2b7

[native] Fix ComposedMessage width constraint to only include content

Description

[native] Fix ComposedMessage width constraint to only include content

Summary:
The avatar should not be part of the width constraint. The width constraint is only meant to apply to the content. This change fixes ENG-3826, and makes the width match for non-viewer and viewer (no avatar) messages.

Our ability to use this fix is actually kind of a coincidence... this diff sidesteps the issue more than anything. It's lucky we don't need to include avatar here... if we did, we would probably be facing a serious React Native bug. Including this simplified non-working example for future reference: https://gist.github.com/Ashoat/f0f00496d17db8df18c2cf21f753f469

Depends on D7697

Test Plan:

beforeafter
Screenshot 2023-05-01 at 4.07.32 PM.png (1×1 px, 924 KB)
Screenshot 2023-05-01 at 4.05.17 PM.png (1×1 px, 951 KB)

Reviewers: ginsu, atul

Reviewed By: ginsu, atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D7698

Details

Provenance
ashoatAuthored on May 1 2023, 12:51 PM
Reviewer
ginsu
Differential Revision
D7698: [native] Fix ComposedMessage width constraint to only include content
Parents
rCOMM6bc1d46e1aef: [native] Rename messageBoxStyle to contentStyle in SwipeableMessage
Branches
Unknown
Tags
Unknown