[native] Rename messageBoxStyle to contentStyle in SwipeableMessage
ClosedPublic
Actions

Authored by ashoat on May 1 2023, 8:06 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM6bc1d46e1aef: [native] Rename messageBoxStyle to contentStyle in SwipeableMessage

Summary

SwipeableMessage now handles the avatar too, so we should rename this property for clarity.

Depends on D7696

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 1 2023, 8:06 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 1 2023, 8:06 PM

ashoat added a child revision: D7698: [native] Fix ComposedMessage width constraint to only include content.May 1 2023, 8:06 PM

ashoat added inline comments.May 1 2023, 8:07 PM

native/chat/composed-message.react.js
160 ↗	(On Diff #25972)	The `swipeableMessageBoxStyle` variable is deleted in the next diff, so I skipped renaming it here

Harbormaster completed remote builds in B18960: Diff 25972.May 1 2023, 8:26 PM

ashoat requested review of this revision.May 1 2023, 8:26 PM

ginsu accepted this revision.May 1 2023, 8:33 PM

This revision is now accepted and ready to land.May 1 2023, 8:33 PM

Closed by commit rCOMM6bc1d46e1aef: [native] Rename messageBoxStyle to contentStyle in SwipeableMessage. · Explain WhyMay 1 2023, 8:55 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6bc1d46e1aef: [native] Rename messageBoxStyle to contentStyle in SwipeableMessage.

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

2 lines

swipeable-message.react.js

10 lines

Diff 25978

View Options

native/chat/composed-message.react.js