Paths

Table of Contentst

[native] Clean up ComposedMessage
ClosedPublic
Actions

Authored by ashoat on May 1 2023, 1:05 PM.

Tags

None

Referenced Files

	F3356406: D7696.id.diff
	Sat, Nov 23, 6:46 PM

	F3356405: D7696.diff
	Sat, Nov 23, 6:46 PM

	Unknown Object (File)
	Sun, Oct 27, 1:26 AM

	Unknown Object (File)
	Oct 25 2024, 7:22 AM

	Unknown Object (File)
	Oct 25 2024, 7:22 AM

	Unknown Object (File)
	Oct 23 2024, 12:55 PM

	Unknown Object (File)
	Oct 23 2024, 11:54 AM

	Unknown Object (File)
	Oct 23 2024, 2:15 AM

View All 82 Files

Subscribers

tomek

Details

Reviewers

ginsu
atul

Commits

rCOMMe1ea3b56bb73: [native] Clean up ComposedMessage

Summary

Two minor fixes here for issues introduced in D7067:

Rename messageBoxStyleContainerStyle to messageBoxContainerStyle (typo)
Avoid inline styles in favor of using combined style sheet (see leftChatContainer and rightChatContainer)

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 1 2023, 1:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 1 2023, 1:05 PM

ashoat added a child revision: D7697: [native] Rename messageBoxStyle to contentStyle in SwipeableMessage.May 1 2023, 1:06 PM

Harbormaster completed remote builds in B18959: Diff 25971.May 1 2023, 1:26 PM

ashoat requested review of this revision.May 1 2023, 1:26 PM

ginsu accepted this revision.May 1 2023, 1:33 PM

This revision is now accepted and ready to land.May 1 2023, 1:33 PM

Closed by commit rCOMMe1ea3b56bb73: [native] Clean up ComposedMessage (authored by ashoat). · Explain WhyMay 1 2023, 1:54 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe1ea3b56bb73: [native] Clean up ComposedMessage.

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

16 lines

Diff 25977

View Options

native/chat/composed-message.react.js

[native] Clean up ComposedMessageClosedPublicActions