HomePhabricator
Diffusion Comm e6709b53bf7e

[identity] Remove device data on device list update

Description

[identity] Remove device data on device list update

Summary:
Resolves ENG-7897.
We should not rely on secondary device removing CSAT and keys on its own. This diff adds a failover mechanism,
that invalidates CSAT and removes device keys when primary device updates the device list, just in case
secondary device failed to remove it before logging out.

These calls are idempotent - they're no-op when CSAT or keys have been already removed.

Depends on D12225

Test Plan:
Secondary logout flow:

  • Commented-out the LogOutSecondaryDevice RPC call
  • Confirmed that device keys were removed from DDB

Reviewers: kamil, varun, will

Reviewed By: kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D12267

Details

Provenance
bartekAuthored on Jun 2 2024, 3:34 AM
Reviewer
kamil
Differential Revision
D12267: [identity] Remove device data on device list update
Parents
rCOMMdb8a21dfe270: [lib][p2p] Update device list upon receiving logout message
Branches
Unknown
Tags
Unknown