Page MenuHomePhabricator

[identity] Remove device data on device list update
ClosedPublic

Authored by bartek on Jun 2 2024, 11:50 PM.
Tags
None
Referenced Files
F3344461: D12267.diff
Fri, Nov 22, 4:37 AM
Unknown Object (File)
Mon, Nov 11, 10:52 PM
Unknown Object (File)
Mon, Nov 11, 10:47 PM
Unknown Object (File)
Mon, Nov 11, 8:03 PM
Unknown Object (File)
Mon, Nov 11, 6:24 PM
Unknown Object (File)
Mon, Nov 11, 3:36 PM
Unknown Object (File)
Sat, Nov 2, 12:18 AM
Unknown Object (File)
Oct 10 2024, 9:30 PM
Subscribers

Details

Summary

Resolves ENG-7897.
We should not rely on secondary device removing CSAT and keys on its own. This diff adds a failover mechanism,
that invalidates CSAT and removes device keys when primary device updates the device list, just in case
secondary device failed to remove it before logging out.

These calls are idempotent - they're no-op when CSAT or keys have been already removed.

Depends on D12225

Test Plan

Secondary logout flow:

  • Commented-out the LogOutSecondaryDevice RPC call
  • Confirmed that device keys were removed from DDB

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable