Page MenuHomePhabricator
Differential D12222

[native] Add dev-only button to log out secondary device
ClosedPublic
Actions

Authored by bartek on May 28 2024, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 11:18 AM
Unknown Object (File)
Thu, Jun 27, 11:18 AM
Unknown Object (File)
Thu, Jun 27, 11:18 AM
Unknown Object (File)
Thu, Jun 27, 11:18 AM
Unknown Object (File)
Fri, Jun 21, 8:43 AM
Unknown Object (File)
Fri, Jun 14, 9:50 AM
Unknown Object (File)
Wed, Jun 12, 12:52 AM
Unknown Object (File)
Tue, Jun 11, 5:32 PM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
varun
Commits
rCOMMfac160b30724: [native] Add dev-only button to log out secondary device
Summary

Added a dev-only button to perform secondary device logout, for test purposes.
I deliberately did not include any checks if given device is primary or secondary, to test the hook behavior from previous diff.
In the future, logout button behavior will depend on whether current device is primary.

Depends on D12221

Test Plan

Pressed the button and repeated test plan from D12221 to check hook behavior.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.May 28 2024, 4:25 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 28 2024, 4:25 AM
bartek added a child revision: D12223: [web] Add dev-only button to log out secondary device.May 28 2024, 4:26 AM
Harbormaster completed remote builds in B29258: Diff 40676.May 28 2024, 4:41 AM
bartek published this revision for review.May 28 2024, 5:19 AM
bartek added reviewers: marcin, varun.Mon, Jun 3, 3:50 AM
bartek added inline comments.
native/profile/profile-screen.react.js
378 ↗(On Diff #40676)

Actually we don't need this TODO here because this is a testing-purpose button.

In the final version, a single logout button will trigger a correct action depending on device being primary or secondary

varun accepted this revision.Wed, Jun 5, 7:01 AM
This revision is now accepted and ready to land.Wed, Jun 5, 7:01 AM
kamil accepted this revision.Thu, Jun 6, 12:30 AM
Closed by commit rCOMMfac160b30724: [native] Add dev-only button to log out secondary device (authored by bartek). · Explain WhyThu, Jun 6, 1:50 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMfac160b30724: [native] Add dev-only button to log out secondary device.
ashoat added inline comments.Thu, Jun 6, 10:21 AM
native/profile/profile-screen.react.js
378

I thought we wanted to remove this TODO

bartek mentioned this in D12604: [native] Add dev-only button for primary device logout.Fri, Jun 28, 2:15 AM

Revision Contents
Changeset List

PathSize
native/
profile/
51 lines

Diff 41026

View Options

native/profile/profile-screen.react.js

Loading...