Paths

Table of Contentst

Differential D12240

[lib] Add unit tests for functions modifying device list
ClosedPublic
Actions

Authored by bartek on May 29 2024, 9:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 19, 11:18 PM

	Unknown Object (File)
	Sat, Jun 15, 5:36 PM

	Unknown Object (File)
	Sat, Jun 15, 2:31 PM

	Unknown Object (File)
	Sat, Jun 15, 12:12 PM

	Unknown Object (File)
	Sun, Jun 9, 10:27 AM

	Unknown Object (File)
	Sat, Jun 8, 10:57 PM

	Unknown Object (File)
	Sat, Jun 8, 4:50 AM

	Unknown Object (File)
	Fri, Jun 7, 5:32 AM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rCOMM5946d727ba67: [lib] Add unit tests for functions modifying device list

Summary

Added unit tests for functions from D12238 and D12239.

Depends on D12239

Test Plan

Unit tests for lib

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 29 2024, 9:49 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 29 2024, 9:49 AM

bartek added a child revision: D12224: [lib] Send logout message to primary device in useSecondaryDeviceLogOut.May 29 2024, 9:50 AM

Harbormaster completed remote builds in B29288: Diff 40753.May 29 2024, 10:07 AM

bartek published this revision for review.May 29 2024, 10:13 AM

nice 👏

lib/shared/device-list-utils.test.js
279 ↗	(On Diff #40753)	can we avoid `any` here and use something like `JestMatcher`?
283 ↗	(On Diff #40753)	looks like a hack but if there isn't any better solution for it probably it's okay as it's only for testing purpose

This revision is now accepted and ready to land.Mon, Jun 3, 4:51 AM

Narrow down matcher type

Harbormaster completed remote builds in B29478: Diff 41024.Thu, Jun 6, 1:24 AM

bartek added inline comments.Thu, Jun 6, 1:49 AM

lib/shared/device-list-utils.test.js
279 ↗	(On Diff #40753)	Checked Flow types of jest matcher and they use `any` 😶 Can narrow down to `Object` which is better
283 ↗	(On Diff #40753)	It is a hack, but thanks to this it also checks one more thing: raw device list JSON should always be ordered: `{ devices, timestamp }`, The order matters because it's signed in this form. Thanks to this, we can serialize and deserialize it at various points and the signature should still be valid

Closed by commit rCOMM5946d727ba67: [lib] Add unit tests for functions modifying device list (authored by bartek). · Explain WhyThu, Jun 6, 1:50 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5946d727ba67: [lib] Add unit tests for functions modifying device list.

Revision Contents
Changeset List

Path

Size

lib/

shared/

device-list-utils.test.js

83 lines

Diff 41029

lib/shared/device-list-utils.test.js

Loading...