[lib][p2p] Update device list upon receiving logout message
ClosedPublic
Actions

Authored by bartek on May 28 2024, 11:28 AM.

Details

Reviewers

kamil

Commits

rCOMMdb8a21dfe270: [lib][p2p] Update device list upon receiving logout message

Summary

Updated p2p message handler to remove device from device list upon receiving logout message

Depends on D12224

Test Plan

In addition to test plan from D12224:

Verified Identity Service logs to see that update_device_list is called
Verified that DDB contains updated device list without secondary device ID (being a sender of the message handled here)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 28 2024, 11:28 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 28 2024, 11:28 AM

Harbormaster failed remote builds in B29261: Diff 40679!May 28 2024, 11:41 AM

Clean up and rebase

bartek retitled this revision from [DRAFT] Update device list upon receiving logout message to [lib][p2p] Update device list upon receiving logout message.May 29 2024, 4:58 PM

bartek edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B29290: Diff 40755.May 29 2024, 5:15 PM

bartek published this revision for review.May 29 2024, 5:16 PM

bartek added inline comments.

lib/handlers/peer-to-peer-message-handler.js
127 ↗	(On Diff #40755)	This will be handled by ENG-7837. I don't want to copy-paste code from `native/secondary-device-qr-code-scanner.js` which is about to be changed as a result of tasks from the linked project