Page MenuHomePhabricator
Differential D12225

[lib][p2p] Update device list upon receiving logout message
ClosedPublic
Actions

Authored by bartek on May 28 2024, 4:28 AM.
Tags
None
Referenced Files
F5095404: D12225.id40755.diff
Sun, Mar 30, 5:43 PM
Unknown Object (File)
Thu, Mar 13, 8:32 AM
Unknown Object (File)
Feb 17 2025, 11:18 AM
Unknown Object (File)
Jan 28 2025, 7:08 PM
Unknown Object (File)
Jan 28 2025, 7:08 PM
Unknown Object (File)
Jan 28 2025, 7:08 PM
Unknown Object (File)
Jan 28 2025, 7:07 PM
Unknown Object (File)
Jan 28 2025, 7:07 PM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMMdb8a21dfe270: [lib][p2p] Update device list upon receiving logout message
Summary

Updated p2p message handler to remove device from device list upon receiving logout message

Depends on D12224

Test Plan

In addition to test plan from D12224:

  • Verified Identity Service logs to see that update_device_list is called
  • Verified that DDB contains updated device list without secondary device ID (being a sender of the message handled here)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.May 28 2024, 4:28 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 28 2024, 4:28 AM
Harbormaster failed remote builds in B29261: Diff 40679!May 28 2024, 4:41 AM
bartek updated this revision to Diff 40755.May 29 2024, 9:50 AM

Clean up and rebase

bartek retitled this revision from [DRAFT] Update device list upon receiving logout message to [lib][p2p] Update device list upon receiving logout message.May 29 2024, 9:58 AM
bartek edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B29290: Diff 40755.May 29 2024, 10:15 AM
bartek published this revision for review.May 29 2024, 10:16 AM
bartek added inline comments.
lib/handlers/peer-to-peer-message-handler.js
127 ↗(On Diff #40755)

This will be handled by ENG-7837. I don't want to copy-paste code from native/secondary-device-qr-code-scanner.js which is about to be changed as a result of tasks from the linked project

bartek added a child revision: D12267: [identity] Remove device data on device list update.Jun 2 2024, 11:50 PM
kamil accepted this revision.Jun 6 2024, 12:55 AM
This revision is now accepted and ready to land.Jun 6 2024, 12:55 AM
Closed by commit rCOMMdb8a21dfe270: [lib][p2p] Update device list upon receiving logout message (authored by bartek). · Explain WhyJun 6 2024, 1:50 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMdb8a21dfe270: [lib][p2p] Update device list upon receiving logout message.

Revision Contents
Changeset List

PathSize
lib/
handlers/
21 lines
shared/
56 lines
native/
profile/
2 lines
qr-code/
27 lines

Diff 40679

View Options

lib/handlers/peer-to-peer-message-handler.js

Show All 11 Linesimport type {
OLMPrekey, OLMPrekey,
} from '../types/crypto-types'; } from '../types/crypto-types';
import type { OlmSessionInitializationInfo } from '../types/request-types'; import type { OlmSessionInitializationInfo } from '../types/request-types';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { values, entries } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Linesfunction getOneTimeKeyValuesFromBlob(keyBlob: string): $ReadOnlyArray<string> {
return getOneTimeKeyValues(oneTimeKeys); return getOneTimeKeyValues(oneTimeKeys);
} }
function getPrekeyValueFromBlob(prekeyBlob: string): string { function getPrekeyValueFromBlob(prekeyBlob: string): string {
const prekey: OLMPrekey = JSON.parse(prekeyBlob); const prekey: OLMPrekey = JSON.parse(prekeyBlob);
return getPrekeyValue(prekey); return getPrekeyValue(prekey);
} }
function getOneTimeKeyArray(
oneTimeKeys: OLMOneTimeKeys,
): $ReadOnlyArray<string> {
return entries(oneTimeKeys.curve25519).map(([key, value]: [string, string]) =>
JSON.stringify({ curve25519: { [key]: value } }),
);
}
export { export {
getOneTimeKeyValues, getOneTimeKeyValues,
getPrekeyValue, getPrekeyValue,
getOneTimeKeyValuesFromBlob, getOneTimeKeyValuesFromBlob,
getPrekeyValueFromBlob, getPrekeyValueFromBlob,
initialEncryptedMessageContent, initialEncryptedMessageContent,
useInitialNotificationsEncryptedMessage, useInitialNotificationsEncryptedMessage,
getOneTimeKeyArray,
}; };
View Options

lib/shared/device-list-utils.js

Show All 11 Linesimport type {
OLMPrekey, OLMPrekey,
} from '../types/crypto-types'; } from '../types/crypto-types';
import type { OlmSessionInitializationInfo } from '../types/request-types'; import type { OlmSessionInitializationInfo } from '../types/request-types';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { values, entries } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Linesfunction getOneTimeKeyValuesFromBlob(keyBlob: string): $ReadOnlyArray<string> {
return getOneTimeKeyValues(oneTimeKeys); return getOneTimeKeyValues(oneTimeKeys);
} }
function getPrekeyValueFromBlob(prekeyBlob: string): string { function getPrekeyValueFromBlob(prekeyBlob: string): string {
const prekey: OLMPrekey = JSON.parse(prekeyBlob); const prekey: OLMPrekey = JSON.parse(prekeyBlob);
return getPrekeyValue(prekey); return getPrekeyValue(prekey);
} }
function getOneTimeKeyArray(
oneTimeKeys: OLMOneTimeKeys,
): $ReadOnlyArray<string> {
return entries(oneTimeKeys.curve25519).map(([key, value]: [string, string]) =>
JSON.stringify({ curve25519: { [key]: value } }),
);
}
export { export {
getOneTimeKeyValues, getOneTimeKeyValues,
getPrekeyValue, getPrekeyValue,
getOneTimeKeyValuesFromBlob, getOneTimeKeyValuesFromBlob,
getPrekeyValueFromBlob, getPrekeyValueFromBlob,
initialEncryptedMessageContent, initialEncryptedMessageContent,
useInitialNotificationsEncryptedMessage, useInitialNotificationsEncryptedMessage,
getOneTimeKeyArray,
}; };
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Show All 11 Linesimport type {
OLMPrekey, OLMPrekey,
} from '../types/crypto-types'; } from '../types/crypto-types';
import type { OlmSessionInitializationInfo } from '../types/request-types'; import type { OlmSessionInitializationInfo } from '../types/request-types';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { values, entries } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Linesfunction getOneTimeKeyValuesFromBlob(keyBlob: string): $ReadOnlyArray<string> {
return getOneTimeKeyValues(oneTimeKeys); return getOneTimeKeyValues(oneTimeKeys);
} }
function getPrekeyValueFromBlob(prekeyBlob: string): string { function getPrekeyValueFromBlob(prekeyBlob: string): string {
const prekey: OLMPrekey = JSON.parse(prekeyBlob); const prekey: OLMPrekey = JSON.parse(prekeyBlob);
return getPrekeyValue(prekey); return getPrekeyValue(prekey);
} }
function getOneTimeKeyArray(
oneTimeKeys: OLMOneTimeKeys,
): $ReadOnlyArray<string> {
return entries(oneTimeKeys.curve25519).map(([key, value]: [string, string]) =>
JSON.stringify({ curve25519: { [key]: value } }),
);
}
export { export {
getOneTimeKeyValues, getOneTimeKeyValues,
getPrekeyValue, getPrekeyValue,
getOneTimeKeyValuesFromBlob, getOneTimeKeyValuesFromBlob,
getPrekeyValueFromBlob, getPrekeyValueFromBlob,
initialEncryptedMessageContent, initialEncryptedMessageContent,
useInitialNotificationsEncryptedMessage, useInitialNotificationsEncryptedMessage,
getOneTimeKeyArray,
}; };
View Options

native/qr-code/qr-code-utils.js

Show All 11 Linesimport type {
OLMPrekey, OLMPrekey,
} from '../types/crypto-types'; } from '../types/crypto-types';
import type { OlmSessionInitializationInfo } from '../types/request-types'; import type { OlmSessionInitializationInfo } from '../types/request-types';
import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js'; import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
CallSingleKeyserverEndpoint, CallSingleKeyserverEndpoint,
} from '../utils/call-single-keyserver-endpoint.js'; } from '../utils/call-single-keyserver-endpoint.js';
import { values, entries } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
export type InitialNotifMessageOptions = { export type InitialNotifMessageOptions = {
+callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint, +callSingleKeyserverEndpoint?: ?CallSingleKeyserverEndpoint,
+callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions, +callSingleKeyserverEndpointOptions?: ?CallSingleKeyserverEndpointOptions,
}; };
const initialEncryptedMessageContent = { const initialEncryptedMessageContent = {
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Linesfunction getOneTimeKeyValuesFromBlob(keyBlob: string): $ReadOnlyArray<string> {
return getOneTimeKeyValues(oneTimeKeys); return getOneTimeKeyValues(oneTimeKeys);
} }
function getPrekeyValueFromBlob(prekeyBlob: string): string { function getPrekeyValueFromBlob(prekeyBlob: string): string {
const prekey: OLMPrekey = JSON.parse(prekeyBlob); const prekey: OLMPrekey = JSON.parse(prekeyBlob);
return getPrekeyValue(prekey); return getPrekeyValue(prekey);
} }
function getOneTimeKeyArray(
oneTimeKeys: OLMOneTimeKeys,
): $ReadOnlyArray<string> {
return entries(oneTimeKeys.curve25519).map(([key, value]: [string, string]) =>
JSON.stringify({ curve25519: { [key]: value } }),
);
}
export { export {
getOneTimeKeyValues, getOneTimeKeyValues,
getPrekeyValue, getPrekeyValue,
getOneTimeKeyValuesFromBlob, getOneTimeKeyValuesFromBlob,
getPrekeyValueFromBlob, getPrekeyValueFromBlob,
initialEncryptedMessageContent, initialEncryptedMessageContent,
useInitialNotificationsEncryptedMessage, useInitialNotificationsEncryptedMessage,
getOneTimeKeyArray,
}; };