HomePhabricator
Diffusion Comm ec22d856adea

[landing] introduce multi paragraph functionality in CompetitorFeature

Description

[landing] introduce multi paragraph functionality in CompetitorFeature

Summary:
The new copy for the long matrix feature comparison descriptions introduces multiple paragraphs. This diff introduces new logic in CompetitorFeature so that it can handle spacing multiple paragraphs the "right way" (not using spaces/newlines, but instead using separate elements and spacing them through margin/padding)

Depends on D8024

Test Plan:
Please see the screenshots/demo below:

Single paragraph:

Screenshot 2023-07-18 at 4.36.35 PM.png (2×3 px, 1020 KB)

multi paragraph:

Screenshot 2023-07-18 at 4.36.32 PM.png (2×3 px, 1011 KB)

demo:

Reviewers: atul, kamil

Reviewed By: kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8537

Details

Provenance
ginsuAuthored on Jul 18 2023, 12:58 PM
Reviewer
kamil
Differential Revision
D8537: [landing] introduce multi paragraph functionality in CompetitorFeature
Parents
rCOMM28060c9a4d86: [landing] introduce competitor feature base component
Branches
Unknown
Tags
Unknown