[landing] introduce multi paragraph functionality in CompetitorFeature
ClosedPublic
Actions

Authored by ginsu on Jul 18 2023, 1:17 PM.

Details

Reviewers

atul
kamil

Commits

rCOMMec22d856adea: [landing] introduce multi paragraph functionality in CompetitorFeature

Summary

The new copy for the long matrix feature comparison descriptions introduces multiple paragraphs. This diff introduces new logic in CompetitorFeature so that it can handle spacing multiple paragraphs the "right way" (not using spaces/newlines, but instead using separate elements and spacing them through margin/padding)

Depends on D8024

Test Plan

Please see the screenshots/demo below:

Single paragraph:

Screenshot 2023-07-18 at 4.36.35 PM.png (2×3 px, 1020 KB)

multi paragraph:

Screenshot 2023-07-18 at 4.36.32 PM.png (2×3 px, 1011 KB)

demo:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 18 2023, 1:17 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 1:17 PM

Harbormaster completed remote builds in B21000: Diff 28790.Jul 18 2023, 1:36 PM

ginsu requested review of this revision.Jul 18 2023, 1:36 PM

ginsu edited the summary of this revision. (Show Details)Jul 18 2023, 1:54 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8024: [landing] introduce competitor feature base component.

ginsu attached a referenced file: F642949: Screen Recording 2023-07-18 at 4.53.20 PM.mov. (Show Details)

ginsu attached a referenced file: F642947: Screenshot 2023-07-18 at 4.36.32 PM.png. (Show Details)

ginsu attached a referenced file: F642946: Screenshot 2023-07-18 at 4.36.35 PM.png. (Show Details)

ginsu added a child revision: D8025: [landing] introduce feature modal component.Jul 18 2023, 1:57 PM

ginsu mentioned this in D7904: [landing] introduce signal competitor data.Jul 18 2023, 2:02 PM

ginsu mentioned this in D8029: [landing] introduce Discord competitor data.Jul 18 2023, 2:04 PM

ginsu mentioned this in D8031: [landing] introduce keybase competitor data.

ginsu mentioned this in D8030: [landing] introduce Matrix competitor data.Jul 18 2023, 2:07 PM

ginsu mentioned this in D8032: [landing] introduce slack competitor data.Jul 18 2023, 2:09 PM

ginsu mentioned this in D8033: [landing] introduce telegram competitor data.

kamil accepted this revision.Jul 19 2023, 5:21 AM

kamil added inline comments.

landing/competitor-feature.react.js
62 ↗	(On Diff #28790)	nit: reduce indentation (there is no need for else if you using `return` in `if`)
78–92 ↗	(On Diff #28790)	can you refactor this to an outside function, taking description and styles as arguments to reduce code duplication?