Page MenuHomePhabricator
Differential D8024

[landing] introduce competitor feature base component
ClosedPublic
Actions

Authored by ginsu on May 29 2023, 7:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 4:20 AM
Unknown Object (File)
Mon, Mar 31, 1:23 AM
Unknown Object (File)
Sun, Mar 30, 4:24 PM
Unknown Object (File)
Sun, Mar 30, 2:04 PM
Unknown Object (File)
Sun, Mar 30, 9:42 AM
Unknown Object (File)
Sun, Mar 30, 4:31 AM
Unknown Object (File)
Fri, Mar 28, 9:15 PM
Unknown Object (File)
Wed, Mar 19, 11:45 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM28060c9a4d86: [landing] introduce competitor feature base component
Summary

The competitor comparison cards and competitor comparison modal will have a similar structure so I factored out the base component so that both places can use this code. A subsequent diff will handle the introduction of the competitor comparison modal. This diff is mainly a move diff

Depends on D7905

Test Plan

The competitor feature cards look and behave the same, and I will do more testing of the competitor comparison modal when I introduce it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 29 2023, 7:37 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 7:37 PM
ginsu edited the summary of this revision. (Show Details)May 29 2023, 7:41 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D7905: [landing] introduce competitor feature card component.
Harbormaster completed remote builds in B19888: Diff 27244.May 29 2023, 7:56 PM
ginsu requested review of this revision.May 29 2023, 7:56 PM
ginsu added a child revision: D8025: [landing] introduce feature modal component.May 29 2023, 11:21 PM
atul accepted this revision.May 30 2023, 7:23 AM
This revision is now accepted and ready to land.May 30 2023, 7:23 AM
ginsu added a child revision: D8537: [landing] introduce multi paragraph functionality in CompetitorFeature.Jul 18 2023, 1:54 PM
ginsu removed a child revision: D8025: [landing] introduce feature modal component.Jul 18 2023, 1:57 PM
ginsu updated this revision to Diff 29657.Aug 8 2023, 12:16 PM

rebase before landing

Harbormaster completed remote builds in B21617: Diff 29657.Aug 8 2023, 1:03 PM
Closed by commit rCOMM28060c9a4d86: [landing] introduce competitor feature base component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM28060c9a4d86: [landing] introduce competitor feature base component.

Revision Contents
Changeset List

PathSize
landing/
40 lines
44 lines
competitor-feature.css
competitor-feature-card.css
17 lines
competitor-feature.react.js
competitor-feature-card.react.js
17 lines

Diff 29732

View Options

landing/competitor-feature-card.css

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines <View {...viewProps}>
<View onLayout={onLayout} ref={viewRef}> <View onLayout={onLayout} ref={viewRef}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}> <AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<InnerRobotextMessage <InnerRobotextMessage
item={item} item={item}
onPress={onPress} onPress={onPress}
onLongPress={onLongPress} onLongPress={onLongPress}
/> />
</AnimatedView> </AnimatedView>
{inlineSidebar}
</View> </View>
{inlineSidebar}
</View> </View>
); );
} }
const unboundStyles = { const unboundStyles = {
sidebar: { sidebar: {
marginTop: -5, marginTop: -5,
marginBottom: 5, marginBottom: 5,
}, },
}; };
export { RobotextMessage }; export { RobotextMessage };
View Options

landing/competitor-feature-card.react.js

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines <View {...viewProps}>
<View onLayout={onLayout} ref={viewRef}> <View onLayout={onLayout} ref={viewRef}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}> <AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<InnerRobotextMessage <InnerRobotextMessage
item={item} item={item}
onPress={onPress} onPress={onPress}
onLongPress={onLongPress} onLongPress={onLongPress}
/> />
</AnimatedView> </AnimatedView>
{inlineSidebar}
</View> </View>
{inlineSidebar}
</View> </View>
); );
} }
const unboundStyles = { const unboundStyles = {
sidebar: { sidebar: {
marginTop: -5, marginTop: -5,
marginBottom: 5, marginBottom: 5,
}, },
}; };
export { RobotextMessage }; export { RobotextMessage };
View Options

landing/competitor-feature.css

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines <View {...viewProps}>
<View onLayout={onLayout} ref={viewRef}> <View onLayout={onLayout} ref={viewRef}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}> <AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<InnerRobotextMessage <InnerRobotextMessage
item={item} item={item}
onPress={onPress} onPress={onPress}
onLongPress={onLongPress} onLongPress={onLongPress}
/> />
</AnimatedView> </AnimatedView>
{inlineSidebar}
</View> </View>
{inlineSidebar}
</View> </View>
); );
} }
const unboundStyles = { const unboundStyles = {
sidebar: { sidebar: {
marginTop: -5, marginTop: -5,
marginBottom: 5, marginBottom: 5,
}, },
}; };
export { RobotextMessage }; export { RobotextMessage };
View Options

landing/competitor-feature.react.js

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines <View {...viewProps}>
<View onLayout={onLayout} ref={viewRef}> <View onLayout={onLayout} ref={viewRef}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}> <AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<InnerRobotextMessage <InnerRobotextMessage
item={item} item={item}
onPress={onPress} onPress={onPress}
onLongPress={onLongPress} onLongPress={onLongPress}
/> />
</AnimatedView> </AnimatedView>
{inlineSidebar}
</View> </View>
{inlineSidebar}
</View> </View>
); );
} }
const unboundStyles = { const unboundStyles = {
sidebar: { sidebar: {
marginTop: -5, marginTop: -5,
marginBottom: 5, marginBottom: 5,
}, },
}; };
export { RobotextMessage }; export { RobotextMessage };