Page MenuHomePhabricator

[landing] introduce slack competitor data
ClosedPublic

Authored by ginsu on May 30 2023, 9:07 AM.
Tags
None
Referenced Files
F4948704: D8032.diff
Wed, Mar 19, 11:18 PM
Unknown Object (File)
Sat, Mar 8, 6:55 PM
Unknown Object (File)
Sat, Mar 8, 9:35 AM
Unknown Object (File)
Tue, Mar 4, 5:54 AM
Unknown Object (File)
Sun, Mar 2, 7:36 PM
Unknown Object (File)
Sun, Mar 2, 7:36 PM
Unknown Object (File)
Fri, Feb 28, 3:45 PM
Unknown Object (File)
Fri, Feb 28, 1:19 PM
Subscribers

Details

Summary

introduce slack competitor data. The copy was copied and pasted from this linear task.

Depends on D8030

Test Plan

Please see screenshots below:

Screenshot 2023-08-06 at 3.37.20 PM.png (2×3 px, 915 KB)

Screenshot 2023-08-06 at 3.37.25 PM.png (2×3 px, 874 KB)

Screenshot 2023-08-06 at 3.37.35 PM.png (2×3 px, 1000 KB)

Screenshot 2023-08-06 at 3.37.30 PM.png (2×3 px, 1009 KB)

Screenshot 2023-08-06 at 3.37.51 PM.png (2×3 px, 968 KB)

Screenshot 2023-08-06 at 3.37.32 PM.png (2×3 px, 968 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.May 30 2023, 9:25 AM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu retitled this revision from DRAFT [landing] introduce slack competitor data to [landing] introduce slack competitor data.
This revision is now accepted and ready to land.Aug 7 2023, 10:29 PM
This revision was automatically updated to reflect the committed changes.