Page MenuHomePhabricator

[landing] introduce keybase competitor data
ClosedPublic

Authored by ginsu on May 30 2023, 9:03 AM.
Tags
None
Referenced Files
F1430865: D8031.id.diff
Wed, Mar 27, 11:54 PM
Unknown Object (File)
Feb 11 2024, 3:23 AM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:03 PM
Unknown Object (File)
Feb 10 2024, 7:03 PM
Unknown Object (File)
Feb 10 2024, 7:03 PM
Subscribers

Details

Summary

introduce Keybase competitor data. The copy was copied and pasted from this linear task.

Depends on D8029

Test Plan

Please see the screenshots below:

Screenshot 2023-07-07 at 4.25.24 PM.png (2×3 px, 883 KB)

Screenshot 2023-07-07 at 4.25.28 PM.png (2×3 px, 820 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.May 30 2023, 9:21 AM
ginsu retitled this revision from DRAFT [landing] introduce keybase competitor data to [landing] introduce keybase competitor data.Jul 10 2023, 1:14 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.

Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that

Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that

I wonder if there's some way to use ' and " throughout the codebase and have "smart quotes" be part of some sort of styling or "rendering" step?

atul added inline comments.
landing/competitor-data.js
122 ↗(On Diff #28564)

This is more of a copy-related thing, so outside of the purview of code review, but it could be a little confusing that we mention "Signal’s Double Ratchet algorithm" in this block and "Comm uses Matrix.org’s implementation of Double Ratchet" in the commDescriptionLong block below.

Wonder if we should make it clear that we're using "Matrix.org's implementation of Signal's Double Ratchet algorithm" in this block to clarify things? Might be too verbose, just a thought.

(cc @ashoat, but feel free to disregard if copy has been finalized)

124 ↗(On Diff #28564)

Is "most apps" referring to

  1. Most apps generally
  2. Most messaging apps
  3. Most E2E encrypted messaging apps

?

Probably pretty clear that it's (3) given context clues, but wonder if it should be specified?

(cc @ashoat, but feel free to disregard if copy has been finalized)

This revision is now accepted and ready to land.Jul 16 2023, 11:25 PM
landing/competitor-data.js
122 ↗(On Diff #28564)

@ginsu brought this up too... I get how it feels ambiguous, but it's correct. I don't think bringing up Matrix.org in this context is super helpful... it clarifies things for somebody who is super deeply in the know, but for somebody who isn't aware of Matrix.org or Olm (great majority of people) I think it will lead to confusion

Although hmmm what if we tried to make it more clear that Signal didn't implement the code we use here? Something like:

Comm uses the Double Ratchet algorithm. Pioneered by Signal, Double Ratchet is the industry standard for E2E encryption.

124 ↗(On Diff #28564)

We can modify this to say "most E2E-encrypted messaging apps" if there's space

updated copy still works and looks great! will update diff momentarily with these new changes

landing/competitor-data.js
122 ↗(On Diff #28564)

Screenshot 2023-07-17 at 1.53.58 PM.png (1×3 px, 929 KB)

124 ↗(On Diff #28564)

Screenshot 2023-07-17 at 1.53.38 PM.png (1×3 px, 993 KB)

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

update double quote character

This revision was automatically updated to reflect the committed changes.