introduce Keybase competitor data. The copy was copied and pasted from this linear task.
Depends on D8029
Details
Details
- Reviewers
atul kamil - Commits
- rCOMM26bd8d289c86: [landing] introduce keybase competitor data
Please see the screenshots below:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that
Comment Actions
Please use rsquo for all apostrophes, and make sure you adjust the whole competitor-data.js file to reflect that
I wonder if there's some way to use ' and " throughout the codebase and have "smart quotes" be part of some sort of styling or "rendering" step?
| landing/competitor-data.js | ||
|---|---|---|
| 122 ↗ | (On Diff #28564) | This is more of a copy-related thing, so outside of the purview of code review, but it could be a little confusing that we mention "Signal’s Double Ratchet algorithm" in this block and "Comm uses Matrix.org’s implementation of Double Ratchet" in the commDescriptionLong block below. Wonder if we should make it clear that we're using "Matrix.org's implementation of Signal's Double Ratchet algorithm" in this block to clarify things? Might be too verbose, just a thought. (cc @ashoat, but feel free to disregard if copy has been finalized) |
| 124 ↗ | (On Diff #28564) | Is "most apps" referring to
? Probably pretty clear that it's (3) given context clues, but wonder if it should be specified? (cc @ashoat, but feel free to disregard if copy has been finalized) |
| landing/competitor-data.js | ||
|---|---|---|
| 122 ↗ | (On Diff #28564) | @ginsu brought this up too... I get how it feels ambiguous, but it's correct. I don't think bringing up Matrix.org in this context is super helpful... it clarifies things for somebody who is super deeply in the know, but for somebody who isn't aware of Matrix.org or Olm (great majority of people) I think it will lead to confusion Although hmmm what if we tried to make it more clear that Signal didn't implement the code we use here? Something like:
|
| 124 ↗ | (On Diff #28564) | We can modify this to say "most E2E-encrypted messaging apps" if there's space |
Comment Actions
change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.