Differential D8038

[landing] add feature cards to competitor comparison
ClosedPublic
Actions

Authored by ginsu on May 31 2023, 8:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 2:19 AM

	Unknown Object (File)
	Sun, Nov 17, 1:36 AM

	Unknown Object (File)
	Sun, Nov 17, 1:36 AM

	Unknown Object (File)
	Sun, Nov 17, 1:36 AM

	Unknown Object (File)
	Sat, Nov 16, 11:27 PM

	Unknown Object (File)
	Mon, Nov 11, 11:34 PM

	Unknown Object (File)
	Oct 18 2024, 11:42 PM

	Unknown Object (File)
	Oct 17 2024, 3:04 AM

View All 84 Files

Subscribers

Details

Reviewers

atul
kamil

Commits

rCOMMb7a77f955fcd: [landing] add feature cards to competitor comparison

Summary

This diff is the second part to the introduction of the competitor comparison. This part introduces the feature cards and all the functionality around it including clicking on a card to view the feature modal and changing the cards based on what competitor was selected

Design:

Screenshot 2023-05-31 at 11.47.29 AM.png (1×3 px, 1 MB)

Depends on D8034

Test Plan

Please watch the demo videos/see the screenshots to see how the competitor comparison looks/behaves with the cards

Desktop/Responsive and General Behavior:

Tablet:

Screenshot 2023-05-31 at 11.55.47 AM.png (2×3 px, 926 KB)

Mobile:

Screenshot 2023-05-31 at 11.55.57 AM.png (2×3 px, 901 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.May 31 2023, 8:53 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 31 2023, 8:53 AM

ginsu edited the summary of this revision. (Show Details)May 31 2023, 8:59 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8034: [landing] introduce competitor comparison.

ginsu attached a referenced file: F566215: Screenshot 2023-05-31 at 11.55.57 AM.png. (Show Details)

ginsu attached a referenced file: F566214: Screenshot 2023-05-31 at 11.55.47 AM.png. (Show Details)

ginsu attached a referenced file: F566207: Screen Recording 2023-05-31 at 11.55.07 AM.mov. (Show Details)

ginsu attached a referenced file: F566206: Screenshot 2023-05-31 at 11.47.29 AM.png. (Show Details)

Harbormaster completed remote builds in B19926: Diff 27301.May 31 2023, 9:10 AM

ginsu requested review of this revision.May 31 2023, 9:10 AM

atul accepted this revision.Jun 1 2023, 11:07 AM

This revision is now accepted and ready to land.Jun 1 2023, 11:07 AM

rebase before landing

Harbormaster completed remote builds in B21627: Diff 29673.Aug 8 2023, 1:34 PM

Closed by commit rCOMMb7a77f955fcd: [landing] add feature cards to competitor comparison (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb7a77f955fcd: [landing] add feature cards to competitor comparison.

Revision Contents
Changeset List

Path

Size

landing/

competitor-comparison.css

21 lines

competitor-comparison.react.js

35 lines

Diff 29743

landing/competitor-comparison.css

Loading...

landing/competitor-comparison.react.js

Loading...