Page MenuHomePhabricator
Differential D10056

Rename IOS to APNs in function responsible for notifications encryption
ClosedPublic
Actions

Authored by marcin on Nov 27 2023, 6:44 AM.
Tags
None
Referenced Files
F3104726: D10056.diff
Wed, Oct 30, 6:20 PM
Unknown Object (File)
Thu, Oct 10, 11:16 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
Commits
rCOMM7a5fb8d380a2: Rename IOS to APNs in function responsible for notifications encryption
Summary

This differential renames functions responsible for notification encryption to use "APNs" instead of "IOS" to emphasize that notifications encryption will
cover all Apple devices.

Test Plan

Ensure that flow and eslint do not complain.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-5383
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 27 2023, 6:44 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 27 2023, 6:44 AM
marcin added a parent revision: D9973: Expose major version of desktop code to the keyserver.Nov 27 2023, 6:45 AM
marcin added a child revision: D10057: Encrypt notifications for MacOS clients with code versions supporting notification decryption.Nov 27 2023, 6:56 AM
Harbormaster completed remote builds in B24523: Diff 33729.Nov 27 2023, 10:01 AM
marcin requested review of this revision.Nov 27 2023, 10:01 AM
michal accepted this revision.Nov 28 2023, 2:19 AM
This revision is now accepted and ready to land.Nov 28 2023, 2:19 AM
marcin updated this revision to Diff 33933.Nov 28 2023, 5:46 AM

Rebase

Harbormaster completed remote builds in B24558: Diff 33933.Nov 28 2023, 6:23 AM
marcin updated this revision to Diff 34032.Nov 30 2023, 2:32 AM

Rebase before landing

marcin updated this revision to Diff 34035.Nov 30 2023, 2:50 AM

Rebase before landing

marcin updated this revision to Diff 34040.Nov 30 2023, 3:18 AM

Rebase before landing

Harbormaster completed remote builds in B24627: Diff 34032.Nov 30 2023, 3:43 AM
Harbormaster completed remote builds in B24630: Diff 34035.Nov 30 2023, 4:19 AM
Harbormaster completed remote builds in B24635: Diff 34040.Nov 30 2023, 5:18 AM
Closed by commit rCOMM7a5fb8d380a2: Rename IOS to APNs in function responsible for notifications encryption (authored by marcin). · Explain WhyNov 30 2023, 5:37 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM7a5fb8d380a2: Rename IOS to APNs in function responsible for notifications encryption.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
10 lines
8 lines

Diff 33729

View Options

keyserver/src/push/crypto.js

Loading...
View Options

keyserver/src/push/send.js

Loading...