Page MenuHomePhabricator

Extend showNotification method to cover the case of decryption error notitication
ClosedPublic

Authored by marcin on Nov 23 2023, 8:48 AM.
Tags
None
Referenced Files
F1761525: D9963.diff
Tue, May 14, 6:44 PM
Unknown Object (File)
Tue, May 14, 3:11 AM
Unknown Object (File)
Mon, Apr 22, 12:47 PM
Unknown Object (File)
Mon, Apr 22, 12:47 PM
Unknown Object (File)
Mon, Apr 22, 12:47 PM
Unknown Object (File)
Mon, Apr 22, 12:46 PM
Unknown Object (File)
Mon, Apr 22, 12:46 PM
Unknown Object (File)
Mon, Apr 22, 12:42 PM
Subscribers

Details

Summary

This differential refactors showNotification method in native desktop code so that it can handle future case of notification that we failed to decrypt. If
we fail to decrypt notification we will either display generic "Comm notification" or add error stack trace to the body depending on whether current user is a staff
member or we are running DEV environment.

Test Plan
  1. Modify listenForNotifications method so that on each notification it calls showNotification twice. The first time with real notification and teh

second time with notification that matched decryption error notification structure (error and displayErrorMessage fields)

  1. Check navigation behaviour of error message notification.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 24 2023, 6:03 AM