Page MenuHomePhabricator

[lib] `RoleInfo` -> `LegacyRoleInfo`
ClosedPublic

Authored by atul on Nov 28 2023, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 6:41 PM
Unknown Object (File)
Fri, Nov 1, 10:04 AM
Unknown Object (File)
Wed, Oct 30, 8:21 PM
Unknown Object (File)
Oct 2 2024, 12:30 AM
Unknown Object (File)
Oct 2 2024, 12:30 AM
Unknown Object (File)
Oct 2 2024, 12:30 AM
Unknown Object (File)
Oct 2 2024, 12:30 AM
Unknown Object (File)
Oct 2 2024, 12:30 AM
Subscribers
None

Details

Summary

All usages of RoleInfo have been updated to support MinimallyEncodedRoleInfo except for

  • createInitialRolesForNewThread
  • fetchRoles
  • addDetailedThreadEditPermissionsToRole
  • addManagePinsThreadPermissionToRole

The first two usages are "between" keyserver and MariaDB. Roles/permissions will continue to be encoded the "old way" in DB for timebeing so updating to handle MinimallyEncodedRoleInfo doesn't make sense.

The second two usages are one-time migrations, so it doesn't make sense to update those.

Test Plan

Just a simple rename so counting on flow/CI/etc.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2023, 6:51 AM
Harbormaster failed remote builds in B24562: Diff 33937!
atul published this revision for review.Nov 28 2023, 6:58 AM

Looks like a simple rename

This revision is now accepted and ready to land.Nov 28 2023, 12:53 PM