Paths

Table of Contentst

Differential D10074

[lib] Re-introduce `RelativeMemberInfo` (`[Legacy/MinimallyEncoded]RelativeMemberInfo`)
ClosedPublic
Actions

Authored by atul on Nov 28 2023, 9:48 AM.

Tags

None

Referenced Files

	F4949212: D10074.diff
	Thu, Mar 20, 3:50 AM

	Unknown Object (File)
	Thu, Feb 27, 7:23 PM

	Unknown Object (File)
	Thu, Feb 27, 7:14 PM

	Unknown Object (File)
	Thu, Feb 27, 7:14 PM

	Unknown Object (File)
	Wed, Feb 26, 8:19 AM

	Unknown Object (File)
	Feb 16 2025, 5:51 PM

	Unknown Object (File)
	Jan 24 2025, 12:18 AM

	Unknown Object (File)
	Jan 23 2025, 11:47 PM

View All 71 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM585efacdc7a5: [lib] Re-introduce `RelativeMemberInfo` (`…

Summary

Similar to D10068 and D10072, but for RelativeMemberInfo.

Note: There are a few places that we haven't updated to support MinimallyEncodedRelativeMemberInfo yet (specifically getRelativeMemberInfos). Those will be handled later in the stack (and will be easier to identify because we'll be able to search for LegacyRelativeMemberInfo and find all instances.

Depends on D10073

Test Plan

flow/CI/etc

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 28 2023, 9:48 AM

atul published this revision for review.Nov 28 2023, 10:02 AM

Harbormaster completed remote builds in B24577: Diff 33953.Nov 28 2023, 10:07 AM

atul added a child revision: D10077: [lib] `RawThreadInfo` -> `LegacyRawThreadInfo`.Nov 28 2023, 12:23 PM

I'm honestly not really reviewing any of these diffs, just blindly accepting

This revision is now accepted and ready to land.Nov 28 2023, 1:23 PM

atul mentioned this in D10078: [lib] Reintroduce `RawThreadInfo` (`[Legacy/MinimallyEncoded]RawThreadInfo`).Nov 28 2023, 1:36 PM

Closed by commit rCOMM585efacdc7a5: [lib] Re-introduce `RelativeMemberInfo` (`… (authored by atul). · Explain WhyNov 29 2023, 3:20 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM585efacdc7a5: [lib] Re-introduce `RelativeMemberInfo` (`….

atul mentioned this in rCOMMbfd6ef196960: [lib] Reintroduce `RawThreadInfo` (`[Legacy/MinimallyEncoded]RawThreadInfo`).

Revision Contents
Changeset List

Path

Size

lib/

selectors/

thread-selectors.js

11 lines

user-selectors.js

10 lines

shared/

11 lines

mention-utils.js

13 lines

thread-utils.js

39 lines

types/

thread-types.js

5 lines

utils/

11 lines

native/

chat/

chat-input-bar.react.js

11 lines

settings/

thread-settings-member-tooltip-modal.react.js

12 lines

thread-settings-member.react.js

9 lines

thread-settings.react.js

11 lines

markdown/

11 lines

roles/

change-roles-screen.react.js

12 lines

web/

input/

11 lines

markdown/

11 lines

modals/

threads/

create/

steps/

subchannel-members-list.react.js

22 lines

members/

change-member-role-modal.react.js

12 lines

member.react.js

12 lines

members-list.react.js

33 lines

members-modal.react.js

14 lines

Diff 34009

lib/selectors/thread-selectors.js

Loading...

lib/selectors/user-selectors.js

Loading...

lib/shared/markdown.js

Loading...

lib/shared/mention-utils.js

Loading...

lib/shared/thread-utils.js

Loading...

lib/types/thread-types.js

Loading...

lib/utils/role-utils.js

Loading...

native/chat/chat-input-bar.react.js

Loading...

native/chat/settings/thread-settings-member-tooltip-modal.react.js

Loading...

native/chat/settings/thread-settings-member.react.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...

native/markdown/rules.react.js

Loading...

native/roles/change-roles-screen.react.js

Loading...

web/input/input-state.js

Loading...

web/markdown/rules.react.js

Loading...

web/modals/threads/create/steps/subchannel-members-list.react.js

Loading...

web/modals/threads/members/change-member-role-modal.react.js

Loading...

web/modals/threads/members/member.react.js

Loading...

web/modals/threads/members/members-list.react.js

Loading...

web/modals/threads/members/members-modal.react.js

Loading...