Differential D10075

[lib] Introduce a special role for Admins
ClosedPublic
Actions

Authored by rohan on Nov 28 2023, 10:39 AM.

Tags

None

Referenced Files

	F5121798: D10075.id33954.diff
	Thu, Apr 3, 11:38 AM

	Unknown Object (File)
	Wed, Apr 2, 4:55 AM

	Unknown Object (File)
	Tue, Apr 1, 8:35 PM

	Unknown Object (File)
	Mon, Mar 31, 11:15 PM

	Unknown Object (File)
	Sat, Mar 29, 9:46 PM

	Unknown Object (File)
	Thu, Mar 20, 2:49 PM

	Unknown Object (File)
	Thu, Mar 20, 2:49 PM

	Unknown Object (File)
	Thu, Mar 20, 2:49 PM

Subscribers

Details

Reviewers

atul
ginsu
tomek

Commits

rCOMMa011993dc8a0: [lib] Introduce a special role for Admins

Summary

We now introduce an enum that maps an ADMIN_ROLE to a number, similar to DEFAULT_ROLE

Addresses ENG-5835

Test Plan

N/A, tested in the next diff

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Nov 28 2023, 10:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2023, 10:39 AM

rohan edited the summary of this revision. (Show Details)Nov 28 2023, 10:40 AM

Harbormaster completed remote builds in B24578: Diff 33954.Nov 28 2023, 10:59 AM

rohan requested review of this revision.Nov 28 2023, 10:59 AM

rohan added a child revision: D10076: [keyserver] Run migration to populate special_role column for Admins.Nov 28 2023, 11:32 AM

atul accepted this revision.Nov 28 2023, 1:37 PM

This revision is now accepted and ready to land.Nov 28 2023, 1:37 PM

Closed by commit rCOMMa011993dc8a0: [lib] Introduce a special role for Admins (authored by rohan). · Explain WhyNov 29 2023, 6:06 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMa011993dc8a0: [lib] Introduce a special role for Admins.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

special-roles.js

2 lines

Diff 33954

lib/permissions/special-roles.js

	Show All 31 Lines		database:
	restart: always			restart: always
	expose:			expose:
	- '3306'			- '3306'
	command: >			command: >
	--performance-schema			--performance-schema
	--max-allowed-packet=256M			--max-allowed-packet=256M
	--local-infile=0			--local-infile=0
	--sql-mode=STRICT_ALL_TABLES			--sql-mode=STRICT_ALL_TABLES
	--innodb-buffer-pool-size=1600M			--innodb-buffer-pool-size=14000M
	--innodb-ft-min-token-size=1			--innodb-ft-min-token-size=1
	--innodb-ft-enable-stopword=0			--innodb-ft-enable-stopword=0
	environment:			environment:
	- MARIADB_RANDOM_ROOT_PASSWORD=yes			- MARIADB_RANDOM_ROOT_PASSWORD=yes
	- MARIADB_DATABASE=$COMM_DATABASE_DATABASE			- MARIADB_DATABASE=$COMM_DATABASE_DATABASE
	- MARIADB_USER=$COMM_DATABASE_USER			- MARIADB_USER=$COMM_DATABASE_USER
	- MARIADB_PASSWORD=$COMM_DATABASE_PASSWORD			- MARIADB_PASSWORD=$COMM_DATABASE_PASSWORD
	- MARIADB_AUTO_UPGRADE=1			- MARIADB_AUTO_UPGRADE=1
	Show All 10 Lines