Page MenuHomePhabricator

[lib] Make registerConfig take full Config instead of $Shape<Config>
ClosedPublic

Authored by ashoat on Nov 28 2023, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 7:29 PM
Unknown Object (File)
Tue, Dec 31, 7:29 PM
Unknown Object (File)
Tue, Dec 31, 7:29 PM
Unknown Object (File)
Tue, Dec 31, 7:29 PM
Unknown Object (File)
Sun, Dec 22, 3:09 PM
Unknown Object (File)
Dec 1 2024, 3:52 PM
Unknown Object (File)
Dec 1 2024, 1:22 PM
Unknown Object (File)
Nov 29 2024, 2:44 PM
Subscribers

Details

Summary

Following the Flow upgrade, I'm looking at replacing all usages of $Shape in our codebase. Context here.

When I swapped this particular $Shape into a Partial, it revealed a type error. We can't set registeredConfig, which is a ?Config, to a Partial<Config>.

Instead I just updated the type to take a Config, which works with both of its callsites anyways.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable