Paths

Table of Contentst

Differential D10085

[flow] Convert all remaining $Shape to $Partial
ClosedPublic
Actions

Authored by ashoat on Nov 28 2023, 8:37 PM.

Details

Reviewers

michal

Commits

rCOMMad9cf36bcf29: [flow] Convert all remaining $Shape to $Partial

Summary

Following the Flow upgrade, I'm looking at replacing all usages of $Shape in our codebase. Context here.

This diff handles all remaining cases, which were automatically updated via flow-upgrade, and did not cause any type errors or require further changes.

Depends on D10084

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 28 2023, 8:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 28 2023, 8:37 PM

ashoat added a child revision: D10086: [lib] Replace Shape<> with $ReadOnly<Partial<>> in MultimediaUploadExtras.Nov 28 2023, 8:39 PM

Harbormaster completed remote builds in B24593: Diff 33972.Nov 28 2023, 9:52 PM

ashoat requested review of this revision.Nov 28 2023, 9:52 PM

michal accepted this revision.Nov 29 2023, 4:18 AM

This revision is now accepted and ready to land.Nov 29 2023, 4:18 AM

Closed by commit rCOMMad9cf36bcf29: [flow] Convert all remaining $Shape to $Partial (authored by ashoat). · Explain WhyNov 29 2023, 10:23 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMad9cf36bcf29: [flow] Convert all remaining $Shape to $Partial.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

deleters/

thread-deleters.js

2 lines

fetchers/

thread-fetchers.js

2 lines

updaters/

thread-permission-updaters.js

2 lines

lib/

shared/

version-utils.js

4 lines

types/

relationship-types.js

2 lines

utils/

action-utils.js

2 lines

keyserver-call.js

2 lines

native/

account/

logged-out-modal.react.js

2 lines

siwe-panel.react.js

2 lines

chat/

chat-thread-list-search.react.js

2 lines

utils/

state-container.js

8 lines

web/

input/

input-state-container.react.js

2 lines

input-state.js

2 lines

Diff 33994

View Options

keyserver/src/deleters/thread-deleters.js

View Options

keyserver/src/fetchers/thread-fetchers.js

View Options

keyserver/src/updaters/thread-permission-updaters.js

View Options

lib/shared/version-utils.js

View Options

lib/types/relationship-types.js

View Options

lib/utils/action-utils.js

View Options

lib/utils/keyserver-call.js

View Options

native/account/logged-out-modal.react.js

View Options

native/account/siwe-panel.react.js

View Options

native/chat/chat-thread-list-search.react.js

View Options

native/utils/state-container.js

View Options

web/input/input-state-container.react.js

View Options

[flow] Convert all remaining $Shape to $PartialClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33994

keyserver/src/deleters/thread-deleters.js

keyserver/src/fetchers/thread-fetchers.js

keyserver/src/updaters/thread-permission-updaters.js

lib/shared/version-utils.js

lib/types/relationship-types.js

lib/utils/action-utils.js

lib/utils/keyserver-call.js

native/account/logged-out-modal.react.js

native/account/siwe-panel.react.js

native/chat/chat-thread-list-search.react.js

native/utils/state-container.js

web/input/input-state-container.react.js

web/input/input-state.js

[flow] Convert all remaining $Shape to $Partial
ClosedPublic
Actions

Revision Contents
Changeset List