Page MenuHomePhabricator
Differential D10085

[flow] Convert all remaining $Shape to $Partial
ClosedPublic
Actions

Authored by ashoat on Nov 28 2023, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Jan 24 2025, 7:52 PM
Unknown Object (File)
Jan 24 2025, 10:54 AM
Unknown Object (File)
Jan 23 2025, 8:56 PM
Unknown Object (File)
Jan 13 2025, 4:38 PM
View All 71 Files
Subscribers
tomek

Details

Reviewers
michal
Commits
rCOMMad9cf36bcf29: [flow] Convert all remaining $Shape to $Partial
Summary

Following the Flow upgrade, I'm looking at replacing all usages of $Shape in our codebase. Context here.

This diff handles all remaining cases, which were automatically updated via flow-upgrade, and did not cause any type errors or require further changes.

Depends on D10084

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
2 lines
fetchers/
2 lines
updaters/
2 lines
lib/
shared/
4 lines
types/
2 lines
utils/
2 lines
2 lines
native/
account/
2 lines
2 lines
chat/
2 lines
utils/
8 lines
web/
input/
2 lines
2 lines

Diff 33994

View Options

keyserver/src/deleters/thread-deleters.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

keyserver/src/fetchers/thread-fetchers.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

keyserver/src/updaters/thread-permission-updaters.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

lib/shared/version-utils.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

lib/types/relationship-types.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesresource "aws_scheduler_schedule" "blob_cleanup" {
# Task can run within 15 minutes window of the scheduled time # Task can run within 15 minutes window of the scheduled time
flexible_time_window { flexible_time_window {
mode = "FLEXIBLE" mode = "FLEXIBLE"
maximum_window_in_minutes = 15 maximum_window_in_minutes = 15
} }
target { target {
arn = aws_ecs_cluster.comm_services.arn arn = aws_ecs_cluster.comm_services.arn
role_arn = aws_iam_role.scheduler.arn role_arn = aws_iam_role.task_scheduler.arn
ecs_parameters { ecs_parameters {
task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision task_definition_arn = aws_ecs_task_definition.blob_cleanup.arn_without_revision
launch_type = "FARGATE" launch_type = "FARGATE"
network_configuration { network_configuration {
assign_public_ip = true assign_public_ip = true
security_groups = [aws_security_group.blob_service.id] security_groups = [aws_security_group.blob_service.id]
subnets = [ subnets = [
aws_subnet.public_a.id, aws_subnet.public_a.id,
aws_subnet.public_b.id, aws_subnet.public_b.id,
aws_subnet.public_c.id, aws_subnet.public_c.id,
] ]
} }
} }
retry_policy { retry_policy {
maximum_event_age_in_seconds = 300 maximum_event_age_in_seconds = 300
maximum_retry_attempts = 5 maximum_retry_attempts = 5
} }
} }
} }
resource "aws_iam_role" "scheduler" { resource "aws_iam_role_policy_attachment" "blob_cleanup_scheduler" {
name = "cron-scheduler-role" policy_arn = aws_iam_policy.blob_cleanup_scheduler.arn
assume_role_policy = jsonencode({ role = aws_iam_role.task_scheduler.name
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Principal = {
Service = ["scheduler.amazonaws.com"]
}
Action = "sts:AssumeRole"
}
]
})
}
resource "aws_iam_role_policy_attachment" "scheduler" {
policy_arn = aws_iam_policy.scheduler.arn
role = aws_iam_role.scheduler.name
} }
resource "aws_iam_policy" "scheduler" { resource "aws_iam_policy" "blob_cleanup_scheduler" {
name = "cron-scheduler-policy" name = "blob-cleanup-cron-scheduler-policy"
policy = jsonencode({ policy = jsonencode({
Version = "2012-10-17" Version = "2012-10-17"
Statement = [ Statement = [
# Allow scheduler to execute the task # Allow scheduler to execute the task
{ {
Effect = "Allow", Effect = "Allow",
Action = [ Action = [
Show All 18 Lines
View Options

lib/utils/action-utils.js

Loading...
View Options

lib/utils/keyserver-call.js

Loading...
View Options

native/account/logged-out-modal.react.js

Loading...
View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/chat/chat-thread-list-search.react.js

Loading...
View Options

native/utils/state-container.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...