Page MenuHomePhabricator
Differential D10084

[native] Add type params to setStateForContainer invocation in setRegisterState
ClosedPublic
Actions

Authored by ashoat on Nov 28 2023, 8:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Fri, Mar 7, 10:50 AM
Unknown Object (File)
Sun, Feb 16, 4:59 PM
Unknown Object (File)
Jan 28 2025, 4:08 AM
Unknown Object (File)
Jan 26 2025, 11:20 AM
Unknown Object (File)
Jan 20 2025, 5:46 AM
View All 67 Files
Subscribers
tomek

Details

Reviewers
michal
Commits
rCOMM581fc1e09574: [native] Add type params to setStateForContainer invocation in setRegisterState
Summary

Following the Flow upgrade, I'm looking at replacing all usages of $Shape in our codebase. Context here.

When I swapped this particular $Shape into a Partial, it caused a Flow error. The Flow error was solved by adding type params to the setStateForContainer invocation.

Depends on D10083

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
4 lines

Diff 33993

View Options

native/account/logged-out-modal.react.js

Show First 20 Lines • Show All 309 Lines • ▼ Show 20 Linestype Props = {
+currentUserCanJoin: boolean, +currentUserCanJoin: boolean,
+threadFrozen: boolean, +threadFrozen: boolean,
+text: string, +text: string,
+setText: (text: string) => void, +setText: (text: string) => void,
+textEdited: boolean, +textEdited: boolean,
+setTextEdited: (edited: boolean) => void, +setTextEdited: (edited: boolean) => void,
+buttonsExpanded: boolean, +buttonsExpanded: boolean,
+setButtonsExpanded: (expanded: boolean) => void, +setButtonsExpanded: (expanded: boolean) => void,
+isExitingDuringEditModeRef: { current: boolean },
}; };
type State = {
+isExitingDuringEditMode: boolean, class ChatInputBar extends React.PureComponent<Props> {
};
class ChatInputBar extends React.PureComponent<Props, State> {
textInput: ?React.ElementRef<typeof TextInput>; textInput: ?React.ElementRef<typeof TextInput>;
clearableTextInput: ?ClearableTextInput; clearableTextInput: ?ClearableTextInput;
selectableTextInput: ?React.ElementRef<typeof SelectableTextInput>; selectableTextInput: ?React.ElementRef<typeof SelectableTextInput>;
expandoButtonsOpen: Value; expandoButtonsOpen: Value;
targetExpandoButtonsOpen: Value; targetExpandoButtonsOpen: Value;
expandoButtonsStyle: AnimatedViewStyle; expandoButtonsStyle: AnimatedViewStyle;
cameraRollIconStyle: AnimatedViewStyle; cameraRollIconStyle: AnimatedViewStyle;
cameraIconStyle: AnimatedViewStyle; cameraIconStyle: AnimatedViewStyle;
expandIconStyle: AnimatedViewStyle; expandIconStyle: AnimatedViewStyle;
sendButtonContainerOpen: Value; sendButtonContainerOpen: Value;
targetSendButtonContainerOpen: Value; targetSendButtonContainerOpen: Value;
sendButtonContainerStyle: AnimatedViewStyle; sendButtonContainerStyle: AnimatedViewStyle;
clearBeforeRemoveListener: () => void; clearBeforeRemoveListener: () => void;
clearFocusListener: () => void; clearFocusListener: () => void;
clearBlurListener: () => void; clearBlurListener: () => void;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
this.state = {
isExitingDuringEditMode: false,
};
this.setUpActionIconAnimations(); this.setUpActionIconAnimations();
this.setUpSendIconAnimations(); this.setUpSendIconAnimations();
} }
setUpActionIconAnimations() { setUpActionIconAnimations() {
this.expandoButtonsOpen = new Value(1); this.expandoButtonsOpen = new Value(1);
this.targetExpandoButtonsOpen = new Value(1); this.targetExpandoButtonsOpen = new Value(1);
const prevTargetExpandoButtonsOpen = new Value(1); const prevTargetExpandoButtonsOpen = new Value(1);
▲ Show 20 Lines • Show All 519 Lines • ▼ Show 20 Linesclass ChatInputBar extends React.PureComponent<Props> {
selectableTextInputRef = ( selectableTextInputRef = (
selectableTextInput: ?React.ElementRef<typeof SelectableTextInput>, selectableTextInput: ?React.ElementRef<typeof SelectableTextInput>,
) => { ) => {
this.selectableTextInput = selectableTextInput; this.selectableTextInput = selectableTextInput;
}; };
updateText = (text: string) => { updateText = (text: string) => {
if (this.state.isExitingDuringEditMode) { if (this.props.isExitingDuringEditModeRef.current) {
return; return;
} }
this.props.setText(text); this.props.setText(text);
this.props.setTextEdited(true); this.props.setTextEdited(true);
this.props.messageEditingContext?.setEditedMessageChanged( this.props.messageEditingContext?.setEditedMessageChanged(
this.isMessageEdited(text), this.isMessageEdited(text),
); );
if (this.isEditMode()) { if (this.isEditMode()) {
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines unblockNavigation = () => {
if (!navigation) { if (!navigation) {
return; return;
} }
navigation.setParams({ removeEditMode: null }); navigation.setParams({ removeEditMode: null });
}; };
removeEditMode: RemoveEditMode = action => { removeEditMode: RemoveEditMode = action => {
const { navigation } = this.props; const { navigation } = this.props;
if (!navigation || this.state.isExitingDuringEditMode) { if (!navigation || this.props.isExitingDuringEditModeRef.current) {
return 'ignore_action'; return 'ignore_action';
} }
if (!this.isMessageEdited()) { if (!this.isMessageEdited()) {
this.unblockNavigation(); this.unblockNavigation();
return 'reduce_action'; return 'reduce_action';
} }
const unblockAndDispatch = () => { const unblockAndDispatch = () => {
this.unblockNavigation(); this.unblockNavigation();
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines this.props.messageEditingContext?.setEditedMessage(null, () => {
this.unblockNavigation(); this.unblockNavigation();
this.updateText(this.props.draft); this.updateText(this.props.draft);
this.focusAndUpdateButtonsVisibility(); this.focusAndUpdateButtonsVisibility();
this.updateSendButton(this.props.draft); this.updateSendButton(this.props.draft);
}); });
}; };
onNavigationFocus = () => { onNavigationFocus = () => {
this.setState({ isExitingDuringEditMode: false }); this.props.isExitingDuringEditModeRef.current = false;
}; };
onNavigationBlur = () => { onNavigationBlur = () => {
if (!this.isEditMode()) { if (!this.isEditMode()) {
return; return;
} }
this.props.setText(this.props.draft); this.props.setText(this.props.draft);
this.setState({ isExitingDuringEditMode: true }, this.exitEditMode); this.props.isExitingDuringEditModeRef.current = true;
this.exitEditMode();
}; };
onNavigationBeforeRemove = (e: { onNavigationBeforeRemove = (e: {
+data: { +action: GenericNavigationAction }, +data: { +action: GenericNavigationAction },
+preventDefault: () => void, +preventDefault: () => void,
... ...
}) => { }) => {
if (!this.isEditMode()) { if (!this.isEditMode()) {
return; return;
} }
const { action } = e.data; const { action } = e.data;
e.preventDefault(); e.preventDefault();
const saveExit = () => { const saveExit = () => {
this.props.messageEditingContext?.setEditedMessage(null, () => { this.props.messageEditingContext?.setEditedMessage(null, () => {
this.setState({ isExitingDuringEditMode: true }, () => { this.props.isExitingDuringEditModeRef.current = true;
if (!this.props.navigation) { this.props.navigation?.dispatch(action);
return;
}
this.props.navigation.dispatch(action);
});
}); });
}; };
if (!this.isMessageEdited()) { if (!this.isMessageEdited()) {
saveExit(); saveExit();
return; return;
} }
exitEditAlert({ exitEditAlert({
onDiscard: saveExit, onDiscard: saveExit,
▲ Show 20 Lines • Show All 214 Lines • ▼ Show 20 Lines const currentUserIsVoiced = useThreadHasPermission(
threadPermissions.VOICED, threadPermissions.VOICED,
); );
const currentUserCanJoin = useThreadHasPermission( const currentUserCanJoin = useThreadHasPermission(
props.threadInfo, props.threadInfo,
threadPermissions.JOIN_THREAD, threadPermissions.JOIN_THREAD,
); );
const isExitingDuringEditModeRef = React.useRef(false);
return ( return (
<ChatInputBar <ChatInputBar
{...props} {...props}
viewerID={viewerID} viewerID={viewerID}
rawThreadInfo={rawThreadInfo} rawThreadInfo={rawThreadInfo}
draft={draft} draft={draft}
joinThreadLoadingStatus={joinThreadLoadingStatus} joinThreadLoadingStatus={joinThreadLoadingStatus}
threadCreationInProgress={threadCreationInProgress} threadCreationInProgress={threadCreationInProgress}
Show All 24 Lines <ChatInputBar
currentUserCanJoin={currentUserCanJoin} currentUserCanJoin={currentUserCanJoin}
threadFrozen={threadFrozen} threadFrozen={threadFrozen}
text={text} text={text}
setText={setText} setText={setText}
textEdited={textEdited} textEdited={textEdited}
setTextEdited={setTextEdited} setTextEdited={setTextEdited}
buttonsExpanded={buttonsExpanded} buttonsExpanded={buttonsExpanded}
setButtonsExpanded={setButtonsExpanded} setButtonsExpanded={setButtonsExpanded}
isExitingDuringEditModeRef={isExitingDuringEditModeRef}
/> />
); );
} }
type DummyChatInputBarProps = { type DummyChatInputBarProps = {
...BaseProps, ...BaseProps,
+onHeightMeasured: (height: number) => mixed, +onHeightMeasured: (height: number) => mixed,
}; };
▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines