[native] Add type params to setStateForContainer invocation in setRegisterState
ClosedPublic
Actions

Authored by ashoat on Nov 28 2023, 8:36 PM.

Details

Reviewers

michal

Commits

rCOMM581fc1e09574: [native] Add type params to setStateForContainer invocation in setRegisterState

Summary

Following the Flow upgrade, I'm looking at replacing all usages of $Shape in our codebase. Context here.

When I swapped this particular $Shape into a Partial, it caused a Flow error. The Flow error was solved by adding type params to the setStateForContainer invocation.

Depends on D10083

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 28 2023, 8:36 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 28 2023, 8:36 PM

ashoat added a child revision: D10085: [flow] Convert all remaining $Shape to $Partial.Nov 28 2023, 8:37 PM

Harbormaster completed remote builds in B24592: Diff 33971.Nov 28 2023, 9:36 PM

ashoat requested review of this revision.Nov 28 2023, 9:36 PM

michal accepted this revision.Nov 29 2023, 4:17 AM

This revision is now accepted and ready to land.Nov 29 2023, 4:17 AM

Closed by commit rCOMM581fc1e09574: [native] Add type params to setStateForContainer invocation in setRegisterState (authored by ashoat). · Explain WhyNov 29 2023, 10:23 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM581fc1e09574: [native] Add type params to setStateForContainer invocation in setRegisterState.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

4 lines

Diff 33971

View Options

native/account/logged-out-modal.react.js

[native] Add type params to setStateForContainer invocation in setRegisterStateClosedPublicActions