Page MenuHomePhabricator
Differential D10102

[identity] increase number of tasks and enable stickiness on load balancer
ClosedPublic
Actions

Authored by varun on Nov 30 2023, 9:07 AM.
Tags
None
Referenced Files
F2018970: D10102.diff
Sun, Jun 16, 3:25 AM
F2016706: D10102.id34063.diff
Sat, Jun 15, 7:29 AM
Unknown Object (File)
Mon, Jun 10, 1:37 AM
Unknown Object (File)
Sun, May 26, 12:12 AM
Unknown Object (File)
Sun, May 26, 12:12 AM
Unknown Object (File)
Sun, May 26, 12:12 AM
Unknown Object (File)
Sun, May 26, 12:12 AM
Unknown Object (File)
Sun, May 26, 12:12 AM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM64515d7a9e8f: [identity] increase number of tasks and enable stickiness on load balancer
Summary

Resolves https://linear.app/comm/issue/ENG-5909/increase-number-of-identity-service-nodes-on-stagingprod

We want to get used to thinking of the identity service as a distributed system. Enabling session stickiness lets us send _finish RPC requests to the same task as the corresponding _start requests by setting a cookie.

Test Plan

https://gist.github.com/vdhanan/07cd60c9474f76d63fa10ef9d909b8ef

used the lb cookie to send a bunch of requests in quick succession, saw in the staging logs that they went to the same task until the cookie expired, at which point they went to both tasks

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Nov 30 2023, 9:07 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 30 2023, 9:07 AM
varun added inline comments.Nov 30 2023, 9:14 AM
services/identity/Dockerfile
1 ↗(On Diff #34059)

i think we need 1.68+ (they optimized cargo builds in 1.68 i believe) to build images now... was running into OOM issues on 1.67

services/terraform/remote/service_identity.tf
2 ↗(On Diff #34059)

ah need to fix this

Harbormaster completed remote builds in B24647: Diff 34059.Nov 30 2023, 9:40 AM
varun requested review of this revision.Nov 30 2023, 9:40 AM
varun updated this revision to Diff 34063.Nov 30 2023, 10:20 AM

fix terraform config

Harbormaster completed remote builds in B24650: Diff 34063.Nov 30 2023, 10:39 AM
varun added a child revision: D10121: [grpc clients] use cookie for finish requests.Nov 30 2023, 6:11 PM
bartek accepted this revision.Dec 1 2023, 12:26 AM
bartek added inline comments.
services/identity/Dockerfile
1 ↗(On Diff #34059)

👍 also changed this in D9058 so one of us needs to rebase

services/terraform/remote/service_identity.tf
2 ↗(On Diff #34063)

Just a note: We're moving to semver versioning, so this is going to be 0.5.0.

I'll be bumping versions anyway so there's no need to re-tag existing images

This revision is now accepted and ready to land.Dec 1 2023, 12:26 AM
Closed by commit rCOMM64515d7a9e8f: [identity] increase number of tasks and enable stickiness on load balancer (authored by varun). · Explain WhyDec 4 2023, 7:23 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM64515d7a9e8f: [identity] increase number of tasks and enable stickiness on load balancer.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
13 lines

Diff 34196

View Options

services/terraform/remote/service_identity.tf

Loading...