Page MenuHomePhabricator
Differential D10191

[web] make database errors more descriptive
ClosedPublic
Actions

Authored by kamil on Dec 5 2023, 3:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 9:02 AM
Unknown Object (File)
Sun, Mar 2, 2:54 AM
Unknown Object (File)
Sat, Mar 1, 2:26 AM
Unknown Object (File)
Sat, Mar 1, 2:26 AM
Unknown Object (File)
Sat, Mar 1, 2:25 AM
Unknown Object (File)
Sat, Mar 1, 2:25 AM
Unknown Object (File)
Feb 9 2025, 6:24 PM
Unknown Object (File)
Jan 24 2025, 11:38 PM
View All 63 Files
Subscribers
ashoat

Details

Reviewers
tomek
michal
Commits
rCOMM4a5aecdcada5: [web] make database errors more descriptive
Summary

This is improvement to: ENG-5910.

Test Plan

Cause error and check if it's logged with details.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
database/
worker/
12 lines

Diff 34276

View Options

web/database/worker/db-worker.js

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines if (oldLastUpdate < viewer.sessionLastUpdated) {
// or the user restored the client app from a backup. Either way, we should // or the user restored the client app from a backup. Either way, we should
// invalidate the existing session, since the server has assumed that the // invalidate the existing session, since the server has assumed that the
// checkpoint is further along than it is on the client, and might not still // checkpoint is further along than it is on the client, and might not still
// have all of the updates necessary to do an incremental update // have all of the updates necessary to do an incremental update
await setNewSession(viewer, calendarQuery, oldLastUpdate); await setNewSession(viewer, calendarQuery, oldLastUpdate);
return { sessionContinued: false }; return { sessionContinued: false };
} }
if (oldLastUpdate === 0 && viewer.sessionLastUpdated === 0) {
// If both oldLastUpdate and viewer.sessionLastUpdated are 0, that indicates
// either a fresh registration, or a fresh login following a policy update
// that requires acknowledgment. In the latter case, we don't want to leave
// oldLastUpdate as 0, as it might result in a lot of old updates being
// downloaded. So we make sure to use Date.now() for the new session, and
// return { sessionContinued: false } to make sure the client gets a
// stateSyncPayloadTypes.FULL.
await setNewSession(viewer, calendarQuery, Date.now());
return { sessionContinued: false };
}
let comparisonResult = null; let comparisonResult = null;
try { try {
comparisonResult = compareNewCalendarQuery(viewer, calendarQuery); comparisonResult = compareNewCalendarQuery(viewer, calendarQuery);
} catch (e) { } catch (e) {
if (e.message !== 'unknown_error') { if (e.message !== 'unknown_error') {
throw e; throw e;
} }
} }
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines