This differential uses encryption API implemented in parent differential to encrypt windows notifications assuming that the client passes introduced code version checks. Additionally a one-liner change is introduced in desktop code that enables Windows clients to handle encrypted notifications.
Details
Details
- Setup ngrok tunneling for http://localhost:3000
- Build windows desktop app following detailed instructions from: https://linear.app/comm/issue/ENG-5859/set-up-environment-for-windows-application-development
- Replace NEXT_CODE_VERSION in version-utils.js with 1 and all isStaffOrDev in cookies.js and send.js with true. (the reason is that to test Windows we have to use production build of the keyserver.
- Connect from Windows app to the keyserver. Ensure that new row in olm_sessions is created.
- Send notifications to Windows client. Ensure that version field of the row created in previous step increments with each notification and each notification is displayed correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/push/send.js | ||
|---|---|---|
| 1310 ↗ | (On Diff #34274) | Theoretically we don't need to specify the web code version. If someone has a new desktop version we know that they will have at least the web version that was on production when the new desktop release was made (because they need to restart the app to get a desktop update). As there are no changes to web required for Windows, when we make a new desktop release we can be sure that they will have at least the current web version. |
Comment Actions
- Remove unecessary web: NEXT_CODE_VERSION from cookies.js in Windows check.
- REbase before landing