Paths

Table of Contentst

Differential D10259

[lib/native] Show resolved ENS name in user profile
ClosedPublic
Actions

Authored by rohan on Dec 8 2023, 7:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 8 2024, 5:32 AM

	Unknown Object (File)
	Feb 21 2024, 1:35 AM

	Unknown Object (File)
	Feb 20 2024, 2:35 PM

	Unknown Object (File)
	Feb 20 2024, 1:55 PM

	Unknown Object (File)
	Feb 20 2024, 10:14 AM

	Unknown Object (File)
	Dec 28 2023, 3:20 AM

	Unknown Object (File)
	Dec 26 2023, 3:47 AM

	Unknown Object (File)
	Dec 26 2023, 2:09 AM

View All 15 Files

Subscribers

Details

Reviewers

ginsu
atul

Commits

rCOMM842832efd32f: [lib/native] Show resolved ENS name in user profile

Summary

Noticed this while working on my ENS work, but the user profile doesn't show the resolved ENS name on both web and native. Thought I'd make this quick change, but @ginsu feel free to let me know if this was either intentional / not the right way to handle this.

Test Plan

Confirmed the ENS name shows if available now

Screenshot 2023-12-08 at 10.05.32 AM.png (1×3 px, 363 KB)

Simulator Screenshot - iPhone 15 Pro - 2023-12-08 at 10.05.19.png (2×1 px, 248 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 8 2023, 7:05 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 7:05 AM

rohan edited the test plan for this revision. (Show Details)Dec 8 2023, 7:06 AM

rohan published this revision for review.Dec 8 2023, 7:43 AM

Harbormaster completed remote builds in B24900: Diff 34432.Dec 8 2023, 8:40 AM

thank you so much for doing this!!

This revision is now accepted and ready to land.Dec 11 2023, 11:51 AM

Closed by commit rCOMM842832efd32f: [lib/native] Show resolved ENS name in user profile (authored by rohan). · Explain WhyDec 11 2023, 4:58 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM842832efd32f: [lib/native] Show resolved ENS name in user profile.

Revision Contents
Changeset List

Path

Size

native/

user-profile/

user-profile.react.js

10 lines

web/

modals/

user-profile/

user-profile.react.js

12 lines

Diff 34493

native/user-profile/user-profile.react.js

Loading...

web/modals/user-profile/user-profile.react.js

Loading...