Page MenuHomePhabricator
Differential D10394

[native] remove android feature
ClosedPublic
Actions

Authored by varun on Dec 18 2023, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 5:20 AM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 16 2025, 10:02 PM
Unknown Object (File)
Feb 15 2025, 7:10 PM
View All 98 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
michal
Commits
rCOMMd822ce2d1d08: [native] remove android feature
Summary

this feature is unnecessary. we can just check the target_os as done in D10263, and set DEVICE_TYPE accordingly.

Test Plan

ran the android emulator and confirmed that DEVICE_TYPE was set to the Android variant by inspecting the version interceptor on identity service. On iOS simulator, DEVICE_TYPE was set to the iOS variant.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
android/
app/
6 lines
2 lines
native_rust_library/
3 lines
src/
11 lines
shared/
cmake/
7 lines

Diff 35332

View Options

native/android/app/CMakeLists.txt

  • This file was added.
.container {
display: flex;
flex-direction: column;
row-gap: 18px;
padding: 16px 12px;
overflow-y: scroll;
flex: 1;
}
View Options

native/android/app/build.gradle

  • This file was added.
.container {
display: flex;
flex-direction: column;
row-gap: 18px;
padding: 16px 12px;
overflow-y: scroll;
flex: 1;
}
View Options

native/native_rust_library/Cargo.toml

  • This file was added.
.container {
display: flex;
flex-direction: column;
row-gap: 18px;
padding: 16px 12px;
overflow-y: scroll;
flex: 1;
}
View Options

native/native_rust_library/src/lib.rs

  • This file was added.
.container {
display: flex;
flex-direction: column;
row-gap: 18px;
padding: 16px 12px;
overflow-y: scroll;
flex: 1;
}
View Options

shared/cmake/corrosion-cxx.cmake

Loading...