Page MenuHomePhabricator
Differential D10394

[native] remove android feature
ClosedPublic
Actions

Authored by varun on Dec 18 2023, 10:58 PM.
Tags
None
Referenced Files
F2191455: D10394.id34860.diff
Thu, Jul 4, 3:43 PM
Unknown Object (File)
Sun, Jun 30, 8:46 PM
Unknown Object (File)
Wed, Jun 26, 4:42 PM
Unknown Object (File)
Tue, Jun 25, 6:51 PM
Unknown Object (File)
Tue, Jun 25, 3:42 PM
Unknown Object (File)
Tue, Jun 25, 12:51 PM
Unknown Object (File)
Tue, Jun 25, 12:20 PM
Unknown Object (File)
Tue, Jun 25, 12:20 PM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
michal
Commits
rCOMMd822ce2d1d08: [native] remove android feature
Summary

this feature is unnecessary. we can just check the target_os as done in D10263, and set DEVICE_TYPE accordingly.

Test Plan

ran the android emulator and confirmed that DEVICE_TYPE was set to the Android variant by inspecting the version interceptor on identity service. On iOS simulator, DEVICE_TYPE was set to the iOS variant.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
android/
app/
6 lines
2 lines
native_rust_library/
3 lines
src/
11 lines
shared/
cmake/
7 lines

Diff 35332

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/android/app/build.gradle

Loading...
View Options

native/native_rust_library/Cargo.toml

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

shared/cmake/corrosion-cxx.cmake

Loading...