Page MenuHomePhabricator
Differential D10394

[native] remove android feature
ClosedPublic
Actions

Authored by varun on Dec 18 2023, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 4:31 AM
Unknown Object (File)
Sat, Mar 29, 2:10 AM
Unknown Object (File)
Mar 1 2025, 5:20 AM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 20 2025, 10:02 PM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
michal
Commits
rCOMMd822ce2d1d08: [native] remove android feature
Summary

this feature is unnecessary. we can just check the target_os as done in D10263, and set DEVICE_TYPE accordingly.

Test Plan

ran the android emulator and confirmed that DEVICE_TYPE was set to the Android variant by inspecting the version interceptor on identity service. On iOS simulator, DEVICE_TYPE was set to the iOS variant.

Diff Detail

Repository
rCOMM Comm
Branch
remove-android-feature (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
android/
app/
6 lines
2 lines
native_rust_library/
3 lines
src/
11 lines
shared/
cmake/
7 lines

Diff 34860

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/android/app/build.gradle

Loading...
View Options

native/native_rust_library/Cargo.toml

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

shared/cmake/corrosion-cxx.cmake

Loading...