Details

Reviewers

Commits

rCOMM3be9c9a59eb6: Use SQLCipher as SQLite engine on web

Summary

This differential compiles SQLCipher-amalgamation as SQLite engine instead of SQLite-amalgamation. Since SQLCipher-amalgamation compilation requires linking
against openssl we additionally compile openssl to emscripten wasm and link SQLCipher-amalgamation against it.

Test Plan

Open web app before creating new WASM to create database handled by original WASM.
Hardcode encryption key in SQLiteQueryExecutor and build new WASM.
Ensure that database is re-encrypted by examining logs from shared worker.
Ensure that app is as usable as before.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-5263

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Dec 22 2023, 7:26 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 22 2023, 7:26 AM

Harbormaster completed remote builds in B25325: Diff 34987.Dec 22 2023, 7:45 AM

marcin requested review of this revision.Dec 22 2023, 7:45 AM

I mentioned this on Linear, but figure it's worth mentioning here too:

I wonder if we should package SQLCipher + OpenSSL as a separate wasm binary. That way, the client would only need to redownload those parts if they change.

In D10450#302237, @ashoat wrote:

I mentioned this on Linear, but figure it's worth mentioning here too:

I wonder if we should package SQLCipher + OpenSSL as a separate wasm binary. That way, the client would only need to redownload those parts if they change.

Responded on Linear

Refactor the script to extract independent steps.
Add no-dso option to OpenSSL compilation configuration. Without this option I was seeing errors like this and I debugged that it originates from this code.