Page MenuHomePhabricator
Differential D10509

Implement C++ file to expose backup API
ClosedPublic
Actions

Authored by marcin on Jan 3 2024, 6:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:08 AM
Unknown Object (File)
Wed, Nov 13, 7:07 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMMbec0c0b8c179: Implement C++ file to expose backup API
Summary

This differential implements C++ class that allows to safely trigger backup creation and restoration from any place in C++ using GlobalDBSingleton. The real
application ofthis class will be exposing C++ backup API to Rust in the very next diff.

Test Plan

The same as for the parent differential but instead of directly calling SQLiteQueryExecutor call methods of this class.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jan 3 2024, 6:30 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 3 2024, 6:30 AM
marcin added a parent revision: D10504: Implement SQLiteQueryExecutor method to restore database from main compaction.Jan 3 2024, 6:37 AM
Harbormaster completed remote builds in B25449: Diff 35154.Jan 3 2024, 6:59 AM
marcin requested review of this revision.Jan 3 2024, 6:59 AM
marcin added a child revision: D10512: Enable backup creation and restoration from Rust.Jan 3 2024, 8:57 AM
kamil resigned from this revision.Jan 5 2024, 5:31 AM

LGTM but @michal needs to confirm as this is strongly connected to his work

michal accepted this revision.Jan 5 2024, 6:30 AM
This revision is now accepted and ready to land.Jan 5 2024, 6:30 AM
marcin updated this revision to Diff 35487.Jan 10 2024, 6:14 AM

Rebase

Harbormaster completed remote builds in B25664: Diff 35487.Jan 10 2024, 6:41 AM
marcin updated this revision to Diff 35664.Jan 16 2024, 5:45 AM

Rebase before landing

Harbormaster failed remote builds in B25795: Diff 35664!Jan 16 2024, 5:59 AM
Harbormaster completed remote builds in B25795: Diff 35664.Jan 16 2024, 6:55 AM
marcin updated this revision to Diff 35684.Jan 16 2024, 9:08 AM

Rebase before landing

Harbormaster completed remote builds in B25809: Diff 35684.Jan 16 2024, 9:29 AM
marcin updated this revision to Diff 35707.Jan 17 2024, 1:32 AM

Rebase before landing

Harbormaster completed remote builds in B25824: Diff 35707.Jan 17 2024, 1:52 AM
marcin updated this revision to Diff 35713.Jan 17 2024, 3:08 AM

Rebase after landing parent diff

This revision was landed with ongoing or failed builds.Jan 17 2024, 3:08 AM
Closed by commit rCOMMbec0c0b8c179: Implement C++ file to expose backup API (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbec0c0b8c179: Implement C++ file to expose backup API.
Harbormaster completed remote builds in B25827: Diff 35713.Jan 17 2024, 3:27 AM

Revision Contents
Changeset List

PathSize
native/
android/
app/
1 line
cpp/
CommonCpp/
NativeModules/
10 lines
PersistentStorageUtilities/
BackupOperationsUtilities/
13 lines
39 lines
ios/
Comm.xcodeproj/
14 lines

Diff 35714

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/BackupOperationsUtilities/BackupOperationsExecutor.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/BackupOperationsUtilities/BackupOperationsExecutor.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...