Paths

Table of Contentst

Enable e2e web notifications to public users
ClosedPublic
Actions

Authored by marcin on Dec 28 2023, 10:34 AM.

Details

Reviewers

inka
atul

Commits

rCOMM65367808efb4: Enable e2e web notifications to public users

Summary

This differential enables E2E encrypted notifications to public users.

Test Plan

Build production web and keyserver.
Ensure notifications are encrypted (check in MariaDB console, by querying olm_sessions table, that version column for row associated with current cookieID

is incrementing with each notif).

Previously testing e2e web notifs on production required to manually remove isStaffOrDev checks.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Dec 28 2023, 10:34 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 28 2023, 10:34 AM

marcin added a child revision: D10482: Enable e2e MacOS notifications to public users.Dec 28 2023, 10:46 AM

Harbormaster completed remote builds in B25376: Diff 35055.Dec 28 2023, 10:53 AM

marcin requested review of this revision.Dec 28 2023, 10:53 AM

I don't have much context on E2EE Web notifications or the cryptosystem, but this seems like a reasonable "flip the switch" diff.

This revision is now accepted and ready to land.Dec 30 2023, 2:05 AM

Rebase before landing

Harbormaster completed remote builds in B25454: Diff 35163.Jan 3 2024, 9:26 AM

Closed by commit rCOMM65367808efb4: Enable e2e web notifications to public users (authored by marcin). · Explain WhyJan 3 2024, 10:19 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM65367808efb4: Enable e2e web notifications to public users.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

10 lines

session/

cookies.js

1 line

Diff 35163

View Options

keyserver/src/push/send.js