Page MenuHomePhabricator
Differential D10556

[native] Reduce branching in `fixUnreadActiveThread`
AbandonedPublic
Actions

Authored by atul on Jan 5 2024, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 6, 12:29 AM
Unknown Object (File)
Fri, Sep 6, 12:29 AM
Unknown Object (File)
Fri, Sep 6, 12:29 AM
Unknown Object (File)
Sep 4 2024, 8:22 PM
Unknown Object (File)
Aug 27 2024, 5:52 PM
Unknown Object (File)
Aug 23 2024, 1:22 PM
Unknown Object (File)
Aug 20 2024, 2:35 PM
Unknown Object (File)
Aug 18 2024, 12:37 PM
View All 26 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Summary

Update fixUnreadActiveThread to only branch on updatedActiveThreadInfo.

Depends on D10555

Test Plan

Careful reading and trusting flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 5 2024, 8:59 AM
atul added a child revision: D10557: [lib] Reduce branching for `updateSubscriptionActionTypes.success` in `thread-reducer`.Jan 5 2024, 9:03 AM
Harbormaster completed remote builds in B25542: Diff 35297.Jan 5 2024, 9:17 AM
atul requested review of this revision.Jan 5 2024, 9:17 AM
ashoat requested changes to this revision.Jan 5 2024, 12:03 PM

Discussed this offline; @atul will summarize conclusions in ENG-6070 and subtasks, but basically we're going to update the ThreadStore type to reflect that only minimally-encoded data are there, and then get rid of (rather than simplify) this branching, as well as all other cases where we branch due to ambiguity in the ThreadStore type

This revision now requires changes to proceed.Jan 5 2024, 12:03 PM
atul abandoned this revision.Jan 5 2024, 12:36 PM

Revision Contents
Changeset List

PathSize
native/
redux/
83 lines

Diff 35297

View Options

native/redux/redux-setup.js

Loading...