Page MenuHomePhabricator

[lib] Reduce branching for `setThreadUnreadStatusActionTypes.started` in `thread-reducer`
AbandonedPublic

Authored by atul on Jan 5 2024, 9:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 6, 12:29 AM
Unknown Object (File)
Fri, Sep 6, 12:29 AM
Unknown Object (File)
Fri, Sep 6, 12:29 AM
Unknown Object (File)
Sep 4 2024, 2:16 AM
Unknown Object (File)
Aug 27 2024, 2:48 PM
Unknown Object (File)
Aug 27 2024, 1:20 PM
Unknown Object (File)
Aug 25 2024, 11:12 AM
Unknown Object (File)
Aug 20 2024, 5:14 PM
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Summary

Remove unnecessary flow branching from setThreadUnreadStatusActionTypes.started.


Depends on D10557

Test Plan

Trusting flow + careful testing

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Jan 5 2024, 9:26 AM
ashoat requested changes to this revision.Jan 5 2024, 12:03 PM

Discussed this offline; @atul will summarize conclusions in ENG-6070 and subtasks, but basically we're going to update the ThreadStore type to reflect that only minimally-encoded data are there, and then get rid of (rather than simplify) this branching, as well as all other cases where we branch due to ambiguity in the ThreadStore type

This revision now requires changes to proceed.Jan 5 2024, 12:03 PM