Page MenuHomePhabricator

[web] introduce chat message list panel item
AcceptedPublic

Authored by ginsu on Jan 8 2024, 12:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 10:09 AM
Unknown Object (File)
Thu, Nov 7, 7:28 AM
Unknown Object (File)
Thu, Nov 7, 3:41 AM
Unknown Object (File)
Thu, Nov 7, 3:09 AM
Unknown Object (File)
Thu, Nov 7, 1:35 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Subscribers

Details

Reviewers
atul
inka
Summary

This diff reintroduces the chat message list back into the chat component and now houses it inside the panel component. To make this happen, I also needed to replace the thread top bar from the chat message list container and instead replace with just the pinned message banner

Linear task: https://linear.app/comm/issue/ENG-5936/message-list-ui-redesign

Depends on D10566

Test Plan

Please see the screenshots below:

w/ pinned messages banner:

Screenshot 2024-01-08 at 3.56.51 AM.png (2×3 px, 975 KB)

w/o pinned messages banner:

Screenshot 2024-01-08 at 3.56.54 AM.png (2×3 px, 940 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu published this revision for review.Jan 8 2024, 1:13 AM

will make sure ci passes before landing

Looks good, question inline about wrapping ChatMessageListContainer with <> </>

web/chat/chat.react.js
37–39

Why do we need to wrap ChatMessageListContainer in <> </>?

This revision is now accepted and ready to land.Jan 8 2024, 12:55 PM