Paths

Table of Contentst

Differential D10567

[web] introduce chat message list panel item
AcceptedPublic
Actions

Authored by ginsu on Jan 8 2024, 12:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 14, 11:02 PM

	Unknown Object (File)
	Sat, Sep 14, 11:01 PM

	Unknown Object (File)
	Sat, Sep 14, 11:01 PM

	Unknown Object (File)
	Jul 20 2024, 12:25 PM

	Unknown Object (File)
	Jul 8 2024, 2:34 AM

	Unknown Object (File)
	Jun 30 2024, 5:09 PM

	Unknown Object (File)
	Jun 24 2024, 12:35 AM

	Unknown Object (File)
	Jun 21 2024, 5:27 PM

View All 24 Files

Subscribers

Details

Reviewers

atul
inka

Summary

This diff reintroduces the chat message list back into the chat component and now houses it inside the panel component. To make this happen, I also needed to replace the thread top bar from the chat message list container and instead replace with just the pinned message banner

Linear task: https://linear.app/comm/issue/ENG-5936/message-list-ui-redesign

Depends on D10566

Test Plan

Please see the screenshots below:

w/ pinned messages banner:

Screenshot 2024-01-08 at 3.56.51 AM.png (2×3 px, 975 KB)

w/o pinned messages banner:

Screenshot 2024-01-08 at 3.56.54 AM.png (2×3 px, 940 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 8 2024, 12:54 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 8 2024, 12:54 AM

ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 1:00 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10566: [web] update the chat input bar ui.

ginsu attached a referenced file: F1043630: Screenshot 2024-01-08 at 3.56.54 AM.png. (Show Details)

ginsu attached a referenced file: F1043629: Screenshot 2024-01-08 at 3.56.51 AM.png. (Show Details)

ginsu added a child revision: D10568: [web] fix edit text message container.Jan 8 2024, 1:04 AM

will make sure ci passes before landing

Harbormaster failed remote builds in B25576: Diff 35343!Jan 8 2024, 1:21 AM

Looks good, question inline about wrapping ChatMessageListContainer with <> </>

web/chat/chat.react.js
37–39	Why do we need to wrap `ChatMessageListContainer` in `<> </>`?

This revision is now accepted and ready to land.Jan 8 2024, 12:55 PM

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-message-list-container.react.js

6 lines

4 lines

30 lines

Diff 35343

web/chat/chat-message-list-container.react.js

Loading...

web/chat/chat.css

Loading...

web/chat/chat.react.js

Loading...