Paths

Table of Contentst

-
native/
-
android/app/src/
-
app/
-
src/
-
cpp/
-
PlatformSpecificTools.cpp
-
main/java/app/comm/android/fbjni/
-
java/
-
app/
-
comm/
-
android/
-
fbjni/
-
PlatformSpecificTools.java
-
cpp/CommonCpp/Tools/
-
CommonCpp/
-
Tools/
-
PlatformSpecificTools.h
-
ios/Comm/
-
Comm/
-
PlatformSpecificTools.mm
-
native_rust_library/
-
RustBackupExecutor.h
-
RustBackupExecutor.cpp
-
src/
-
lib.rs

[native] Filepath generation for log and userkeys data
ClosedPublic
Actions

Authored by michal on Jan 11 2024, 7:46 AM.

Details

Reviewers

marcin
kamil

Commits

rCOMMb0967842639c: [native] Filepath generation for log and userkeys data

Summary

ENG-6216 : Add rust code for getting filepath with compations/logs
Adds two new functions for files used for backup data storage on the device (while they are waiting to be confirmed by backup service): one for logs (with optional attachments file) and the second one for userkeys file.

Additionally changes the functions to take &str (rust::Str) instead of String (rust::String) as we are making a copy of them to std::string immediately and don't need to pass an owned string.

Depends on D10604

Test Plan

Called these functions from rust and got these results:

backup-123-userkeys
backup-123-log-456
backup-123-log-456-attachments

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jan 11 2024, 7:46 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 7:46 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 7:52 AM

Harbormaster failed remote builds in B25699: Diff 35535!

Fix android

michal edited the summary of this revision. (Show Details)Jan 12 2024, 6:24 AM

Harbormaster completed remote builds in B25723: Diff 35571.Jan 12 2024, 6:41 AM

michal requested review of this revision.Jan 12 2024, 6:41 AM

marcin accepted this revision.Jan 12 2024, 7:50 AM

This revision is now accepted and ready to land.Jan 12 2024, 7:50 AM

Closed by commit rCOMMb0967842639c: [native] Filepath generation for log and userkeys data (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 16 2024, 7:56 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMb0967842639c: [native] Filepath generation for log and userkeys data.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

cpp/

PlatformSpecificTools.cpp

40 lines

main/

java/

app/

comm/

android/

fbjni/

PlatformSpecificTools.java

20 lines

cpp/

CommonCpp/

Tools/

PlatformSpecificTools.h

5 lines

ios/

Comm/

PlatformSpecificTools.mm

32 lines

native_rust_library/

RustBackupExecutor.h

5 lines

RustBackupExecutor.cpp

13 lines

src/

lib.rs

14 lines

Diff 35680

View Options

native/android/app/src/cpp/PlatformSpecificTools.cpp

	Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
	export const ThreadSettingsNotificationsRouteName =			export const ThreadSettingsNotificationsRouteName =
	'ThreadSettingsNotifications';			'ThreadSettingsNotifications';
	export const IntroTipRouteName = 'IntroTip';			export const IntroTipRouteName = 'IntroTip';
	export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';			export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
	export const HomeTabTipRouteName = 'HomeTabTip';			export const HomeTabTipRouteName = 'HomeTabTip';
	export const MutedTabTipRouteName = 'MutedTabTip';			export const MutedTabTipRouteName = 'MutedTabTip';
	export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';			export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
	export const QRAuthNavigatorRouteName = 'QRAuthNavigator';			export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
				export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
	export type UserProfileBottomSheetParamList = {			export type UserProfileBottomSheetParamList = {
	+UserProfileBottomSheet: UserProfileBottomSheetParams,			+UserProfileBottomSheet: UserProfileBottomSheetParams,
	+UserProfileAvatarModal: UserProfileAvatarModalParams,			+UserProfileAvatarModal: UserProfileAvatarModalParams,
	+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,			+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
	};			};

	export type QRAuthNavigatorParamList = {			export type QRAuthNavigatorParamList = {
	+SecondaryDeviceQRCodeScanner: void,			+SecondaryDeviceQRCodeScanner: void,
				+QRAuthNotPrimaryDevice: void,
	};			};

	export type ScreenParamList = {			export type ScreenParamList = {
	...RootParamList,			...RootParamList,
	...OverlayParamList,			...OverlayParamList,
	...TabParamList,			...TabParamList,
	...ChatParamList,			...ChatParamList,
	...ChatTopTabsParamList,			...ChatTopTabsParamList,
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

View Options

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

	Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
	export const ThreadSettingsNotificationsRouteName =			export const ThreadSettingsNotificationsRouteName =
	'ThreadSettingsNotifications';			'ThreadSettingsNotifications';
	export const IntroTipRouteName = 'IntroTip';			export const IntroTipRouteName = 'IntroTip';
	export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';			export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
	export const HomeTabTipRouteName = 'HomeTabTip';			export const HomeTabTipRouteName = 'HomeTabTip';
	export const MutedTabTipRouteName = 'MutedTabTip';			export const MutedTabTipRouteName = 'MutedTabTip';
	export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';			export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
	export const QRAuthNavigatorRouteName = 'QRAuthNavigator';			export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
				export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
	export type UserProfileBottomSheetParamList = {			export type UserProfileBottomSheetParamList = {
	+UserProfileBottomSheet: UserProfileBottomSheetParams,			+UserProfileBottomSheet: UserProfileBottomSheetParams,
	+UserProfileAvatarModal: UserProfileAvatarModalParams,			+UserProfileAvatarModal: UserProfileAvatarModalParams,
	+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,			+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
	};			};

	export type QRAuthNavigatorParamList = {			export type QRAuthNavigatorParamList = {
	+SecondaryDeviceQRCodeScanner: void,			+SecondaryDeviceQRCodeScanner: void,
				+QRAuthNotPrimaryDevice: void,
	};			};

	export type ScreenParamList = {			export type ScreenParamList = {
	...RootParamList,			...RootParamList,
	...OverlayParamList,			...OverlayParamList,
	...TabParamList,			...TabParamList,
	...ChatParamList,			...ChatParamList,
	...ChatTopTabsParamList,			...ChatTopTabsParamList,
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

View Options

native/cpp/CommonCpp/Tools/PlatformSpecificTools.h

	Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
	export const ThreadSettingsNotificationsRouteName =			export const ThreadSettingsNotificationsRouteName =
	'ThreadSettingsNotifications';			'ThreadSettingsNotifications';
	export const IntroTipRouteName = 'IntroTip';			export const IntroTipRouteName = 'IntroTip';
	export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';			export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
	export const HomeTabTipRouteName = 'HomeTabTip';			export const HomeTabTipRouteName = 'HomeTabTip';
	export const MutedTabTipRouteName = 'MutedTabTip';			export const MutedTabTipRouteName = 'MutedTabTip';
	export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';			export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
	export const QRAuthNavigatorRouteName = 'QRAuthNavigator';			export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
				export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
	export type UserProfileBottomSheetParamList = {			export type UserProfileBottomSheetParamList = {
	+UserProfileBottomSheet: UserProfileBottomSheetParams,			+UserProfileBottomSheet: UserProfileBottomSheetParams,
	+UserProfileAvatarModal: UserProfileAvatarModalParams,			+UserProfileAvatarModal: UserProfileAvatarModalParams,
	+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,			+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
	};			};

	export type QRAuthNavigatorParamList = {			export type QRAuthNavigatorParamList = {
	+SecondaryDeviceQRCodeScanner: void,			+SecondaryDeviceQRCodeScanner: void,
				+QRAuthNotPrimaryDevice: void,
	};			};

	export type ScreenParamList = {			export type ScreenParamList = {
	...RootParamList,			...RootParamList,
	...OverlayParamList,			...OverlayParamList,
	...TabParamList,			...TabParamList,
	...ChatParamList,			...ChatParamList,
	...ChatTopTabsParamList,			...ChatTopTabsParamList,
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

View Options

native/ios/Comm/PlatformSpecificTools.mm

	Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
	export const ThreadSettingsNotificationsRouteName =			export const ThreadSettingsNotificationsRouteName =
	'ThreadSettingsNotifications';			'ThreadSettingsNotifications';
	export const IntroTipRouteName = 'IntroTip';			export const IntroTipRouteName = 'IntroTip';
	export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';			export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
	export const HomeTabTipRouteName = 'HomeTabTip';			export const HomeTabTipRouteName = 'HomeTabTip';
	export const MutedTabTipRouteName = 'MutedTabTip';			export const MutedTabTipRouteName = 'MutedTabTip';
	export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';			export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
	export const QRAuthNavigatorRouteName = 'QRAuthNavigator';			export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
				export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
	export type UserProfileBottomSheetParamList = {			export type UserProfileBottomSheetParamList = {
	+UserProfileBottomSheet: UserProfileBottomSheetParams,			+UserProfileBottomSheet: UserProfileBottomSheetParams,
	+UserProfileAvatarModal: UserProfileAvatarModalParams,			+UserProfileAvatarModal: UserProfileAvatarModalParams,
	+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,			+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
	};			};

	export type QRAuthNavigatorParamList = {			export type QRAuthNavigatorParamList = {
	+SecondaryDeviceQRCodeScanner: void,			+SecondaryDeviceQRCodeScanner: void,
				+QRAuthNotPrimaryDevice: void,
	};			};

	export type ScreenParamList = {			export type ScreenParamList = {
	...RootParamList,			...RootParamList,
	...OverlayParamList,			...OverlayParamList,
	...TabParamList,			...TabParamList,
	...ChatParamList,			...ChatParamList,
	...ChatTopTabsParamList,			...ChatTopTabsParamList,
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

View Options

native/native_rust_library/RustBackupExecutor.h

	Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
	export const ThreadSettingsNotificationsRouteName =			export const ThreadSettingsNotificationsRouteName =
	'ThreadSettingsNotifications';			'ThreadSettingsNotifications';
	export const IntroTipRouteName = 'IntroTip';			export const IntroTipRouteName = 'IntroTip';
	export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';			export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
	export const HomeTabTipRouteName = 'HomeTabTip';			export const HomeTabTipRouteName = 'HomeTabTip';
	export const MutedTabTipRouteName = 'MutedTabTip';			export const MutedTabTipRouteName = 'MutedTabTip';
	export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';			export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
	export const QRAuthNavigatorRouteName = 'QRAuthNavigator';			export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
				export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
	export type UserProfileBottomSheetParamList = {			export type UserProfileBottomSheetParamList = {
	+UserProfileBottomSheet: UserProfileBottomSheetParams,			+UserProfileBottomSheet: UserProfileBottomSheetParams,
	+UserProfileAvatarModal: UserProfileAvatarModalParams,			+UserProfileAvatarModal: UserProfileAvatarModalParams,
	+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,			+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
	};			};

	export type QRAuthNavigatorParamList = {			export type QRAuthNavigatorParamList = {
	+SecondaryDeviceQRCodeScanner: void,			+SecondaryDeviceQRCodeScanner: void,
				+QRAuthNotPrimaryDevice: void,
	};			};

	export type ScreenParamList = {			export type ScreenParamList = {
	...RootParamList,			...RootParamList,
	...OverlayParamList,			...OverlayParamList,
	...TabParamList,			...TabParamList,
	...ChatParamList,			...ChatParamList,
	...ChatTopTabsParamList,			...ChatTopTabsParamList,
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

View Options

native/native_rust_library/RustBackupExecutor.cpp

	Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
	export const ThreadSettingsNotificationsRouteName =			export const ThreadSettingsNotificationsRouteName =
	'ThreadSettingsNotifications';			'ThreadSettingsNotifications';
	export const IntroTipRouteName = 'IntroTip';			export const IntroTipRouteName = 'IntroTip';
	export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';			export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
	export const HomeTabTipRouteName = 'HomeTabTip';			export const HomeTabTipRouteName = 'HomeTabTip';
	export const MutedTabTipRouteName = 'MutedTabTip';			export const MutedTabTipRouteName = 'MutedTabTip';
	export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';			export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
	export const QRAuthNavigatorRouteName = 'QRAuthNavigator';			export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
				export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
	export type UserProfileBottomSheetParamList = {			export type UserProfileBottomSheetParamList = {
	+UserProfileBottomSheet: UserProfileBottomSheetParams,			+UserProfileBottomSheet: UserProfileBottomSheetParams,
	+UserProfileAvatarModal: UserProfileAvatarModalParams,			+UserProfileAvatarModal: UserProfileAvatarModalParams,
	+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,			+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
	};			};

	export type QRAuthNavigatorParamList = {			export type QRAuthNavigatorParamList = {
	+SecondaryDeviceQRCodeScanner: void,			+SecondaryDeviceQRCodeScanner: void,
				+QRAuthNotPrimaryDevice: void,
	};			};

	export type ScreenParamList = {			export type ScreenParamList = {
	...RootParamList,			...RootParamList,
	...OverlayParamList,			...OverlayParamList,
	...TabParamList,			...TabParamList,
	...ChatParamList,			...ChatParamList,
	...ChatTopTabsParamList,			...ChatTopTabsParamList,
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

View Options

native/native_rust_library/src/lib.rs

[native] Filepath generation for log and userkeys dataClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35680

native/android/app/src/cpp/PlatformSpecificTools.cpp

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

native/cpp/CommonCpp/Tools/PlatformSpecificTools.h

native/ios/Comm/PlatformSpecificTools.mm

native/native_rust_library/RustBackupExecutor.h

native/native_rust_library/RustBackupExecutor.cpp

native/native_rust_library/src/lib.rs

[native] Filepath generation for log and userkeys data
ClosedPublic
Actions

Revision Contents
Changeset List