Jest and JSI CodeGen workflows
AbandonedPublic
Actions

Authored by atul on Jan 12 2024, 1:04 PM.

Details

Reviewers

ashoat
bartek

Summary

Addressing @bartek's comment: https://phab.comm.dev/D10561#inline-64867

Test Plan

None, we'll know if it fails.

Diff Detail

Repository

rCOMM Comm

Branch

buildkite-node (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 12 2024, 1:04 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 12 2024, 1:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2024, 1:16 PM

Harbormaster failed remote builds in B25730: Diff 35579!

atul requested review of this revision.Jan 12 2024, 1:19 PM

atul added inline comments.

.buildkite/jsi_codegen.yml
14	We didn't really need to specify which version of Debian here. Defaults to latest version of Debian anyways. These are all aliases for the same thing:

atul attached a referenced file: F1057741: ca8aed.png. (Show Details)Jan 12 2024, 1:19 PM

atul mentioned this in D10561: [nix] Upgrade to latest version of nixpkgs-unstable.

atul planned changes to this revision.Jan 12 2024, 11:36 PM

Re. failing Codegen JSI

fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm

Not sure what started to cause this, but I had the exact same problem with the "gRPC-Web Codegen CI" job and fixed it by adding the following command:

steps:
  - label: 'Foo'
    command:
      - 'git config --global --add safe.directory "*"'
      - ...

In D10622#307511, @bartek wrote:
Re. failing Codegen JSI
fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm
Not sure what started to cause this, but I had the exact same problem with the "gRPC-Web Codegen CI" job and fixed it by adding the following command:
steps:
  - label: 'Foo'
    command:
      - 'git config --global --add safe.directory "*"'
      - ...

Oh this is huge, thank you!

It also clarifies a misunderstanding I had with the Emscripten workflow. I'll put up a diff fixing that up as well.

This was done by @ashoat in D11493.

Revision Contents
Changeset List

Path

Size

.buildkite/

eslint_flow_jest.yml

2 lines

jsi_codegen.yml

2 lines

Diff 35579

View Options

.buildkite/eslint_flow_jest.yml

Show All 35 Lines	public struct VideoInfo: Record {
var format: String = "N/A"		var format: String = "N/A"
}		}

public class MediaModule: Module {		public class MediaModule: Module {
public func definition() -> ModuleDefinition {		public func definition() -> ModuleDefinition {
Name("MediaModule")		Name("MediaModule")

AsyncFunction("getVideoInfo", getVideoInfo)		AsyncFunction("getVideoInfo", getVideoInfo)
		AsyncFunction("hasMultipleFrames", hasMultipleFrames)
}		}


// MARK: - Function implementations		// MARK: - Function implementations

private func getVideoInfo(path: URL) throws -> VideoInfo {		private func getVideoInfo(path: URL) throws -> VideoInfo {
let asset = AVAsset(url: path)		let asset = AVAsset(url: path)

Show All 15 Lines	private func getVideoInfo(path: URL) throws -> VideoInfo {
} else {		} else {
throw NoVideoTrackException(path)		throw NoVideoTrackException(path)
}		}

videoInfo.format = path.pathExtension		videoInfo.format = path.pathExtension

return videoInfo		return videoInfo
}		}

		private func hasMultipleFrames(path: URL) throws -> Bool {
		guard let imageSource = CGImageSourceCreateWithURL(path as CFURL, nil) else {
		throw FailedToLoadGifException(path)
		}

		let count = CGImageSourceGetCount(imageSource)

		return count > 1
		}
}		}

// MARK: - Exception definitions		// MARK: - Exception definitions

private class NoVideoTrackException: GenericException<URL> {		private class NoVideoTrackException: GenericException<URL> {
override var reason: String {		override var reason: String {
"No video track found in file URI: \(param)"		"No video track found in file URI: \(param)"
}		}
}		}

		private class FailedToLoadGifException: GenericException<URL> {
		override var reason: String {
		"Failed to load gif at URI: \(param)"
		}
		}