Page MenuHomePhabricator

[Buildkite] Bump `node` for ESLint/Flow/Jest and JSI CodeGen workflows
Changes PlannedPublic

Authored by atul on Jan 12 2024, 1:04 PM.
Tags
None
Referenced Files
F2191319: D10622.diff
Thu, Jul 4, 3:05 PM
Unknown Object (File)
Tue, Jun 18, 9:29 PM
Unknown Object (File)
Sat, Jun 15, 1:20 PM
Unknown Object (File)
Mon, Jun 10, 1:49 AM
Unknown Object (File)
Sun, Jun 9, 10:58 PM
Unknown Object (File)
Thu, Jun 6, 1:15 PM
Unknown Object (File)
May 23 2024, 3:02 AM
Unknown Object (File)
May 20 2024, 12:34 PM
Subscribers

Details

Reviewers
ashoat
bartek
Summary
Test Plan

None, we'll know if it fails.

Diff Detail

Repository
rCOMM Comm
Branch
buildkite-node (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2024, 1:16 PM
Harbormaster failed remote builds in B25730: Diff 35579!
atul requested review of this revision.Jan 12 2024, 1:19 PM
atul added inline comments.
.buildkite/jsi_codegen.yml
14

We didn't really need to specify which version of Debian here. Defaults to latest version of Debian anyways. These are all aliases for the same thing:

ca8aed.png (120×1 px, 23 KB)

Re. failing Codegen JSI

fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm

Not sure what started to cause this, but I had the exact same problem with the "gRPC-Web Codegen CI" job and fixed it by adding the following command:

steps:
  - label: 'Foo'
    command:
      - 'git config --global --add safe.directory "*"'
      - ...

Re. failing Codegen JSI

fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm

Not sure what started to cause this, but I had the exact same problem with the "gRPC-Web Codegen CI" job and fixed it by adding the following command:

steps:
  - label: 'Foo'
    command:
      - 'git config --global --add safe.directory "*"'
      - ...

Oh this is huge, thank you!

It also clarifies a misunderstanding I had with the Emscripten workflow. I'll put up a diff fixing that up as well.