Details

Reviewers

tomek
inka
ashoat

Commits

rCOMMe0aceb05b71e: [native] use useChangeIdentityUserPassword

Summary

this change lets users change their password on the identity service from native

Depends on D10616

Test Plan

successfully registered a password user, manually updated relevant state, changed their password, and then successfully logged in with the new password

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jan 13 2024, 7:31 AM

Harbormaster completed remote builds in B25735: Diff 35584.Jan 13 2024, 7:50 AM

varun requested review of this revision.Jan 13 2024, 7:50 AM

This code looks right with the API as-is, but unfortunately in D10616 I realized that we're missing a step where we confirm the existing password. I think that will require updates here unfortunately

This revision now requires changes to proceed.Jan 14 2024, 2:50 AM

match whitepaper

ashoat accepted this revision.Jun 18 2024, 5:10 PM

This revision is now accepted and ready to land.Jun 18 2024, 5:10 PM

fix logic

Harbormaster completed remote builds in B29751: Diff 41458.Jun 18 2024, 5:26 PM

Harbormaster completed remote builds in B29752: Diff 41459.Jun 18 2024, 5:30 PM

varun added a child revision: D12468: [web] allow password users registered with identity to change their password from web.Jun 18 2024, 5:56 PM

improve error handling

Harbormaster completed remote builds in B29762: Diff 41470.Jun 18 2024, 9:06 PM

Closed by commit rCOMMe0aceb05b71e: [native] use useChangeIdentityUserPassword. · Explain WhyJun 19 2024, 1:39 PM

This revision was automatically updated to reflect the committed changes.