Paths

Table of Contentst

Differential D12465

[identity] update change password RPCs to match whitepaper
ClosedPublic
Actions

Authored by varun on Tue, Jun 18, 9:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 30, 5:20 AM

	Unknown Object (File)
	Sat, Jun 29, 8:30 PM

	Unknown Object (File)
	Fri, Jun 28, 8:33 AM

	Unknown Object (File)
	Fri, Jun 28, 12:37 AM

	Unknown Object (File)
	Thu, Jun 27, 4:34 PM

	Unknown Object (File)
	Thu, Jun 27, 11:20 AM

	Unknown Object (File)
	Thu, Jun 27, 1:16 AM

	Unknown Object (File)
	Tue, Jun 25, 5:05 PM

View All 25 Files

Subscribers

Details

Reviewers

ashoat
bartek

Commits

rCOMMa0954eecab3e: [identity] update change password RPCs to match whitepaper

Summary

per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password.

Test Plan

tested later in stack by calling the new RPCs from web and native

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Tue, Jun 18, 9:41 AM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Jun 18, 9:41 AM

varun added a child revision: D10616: [lib][native][web] add new changeIdentityUserPassword action.Tue, Jun 18, 9:58 AM

Harbormaster completed remote builds in B29748: Diff 41455.Tue, Jun 18, 9:58 AM

varun requested review of this revision.Tue, Jun 18, 9:58 AM

ashoat accepted this revision.Tue, Jun 18, 10:07 AM

ashoat added inline comments.

native/schema/CommRustModuleSchema.js
88–94 ↗	(On Diff #41455)	Does nothing currently call this?
shared/protos/identity_auth.proto
191–198 ↗	(On Diff #41455)	Nit: I would move this above `UpdateUserPasswordFinishRequest` to properly reflect the order in which the messages are passed

use username as credential identifier

native/schema/CommRustModuleSchema.js
88–94 ↗	(On Diff #41455)	yeah no callsites
shared/protos/identity_auth.proto
191–198 ↗	(On Diff #41455)	sure will change this before landing

varun added inline comments.Tue, Jun 18, 1:50 PM

shared/protos/identity_auth.proto
191–198 ↗	(On Diff #41455)	actually the order here determines the ordering in our gRPC-web codegen files. i'd rather not move everything around in those files

Harbormaster completed remote builds in B29761: Diff 41469.Tue, Jun 18, 2:03 PM

ashoat added inline comments.Tue, Jun 18, 2:20 PM

shared/protos/identity_auth.proto
191–198 ↗	(On Diff #41455)	That's fair

You're doing OPAQUE login for old password and OPAQUE registration for new password in the same RPC. Smart!

This revision is now accepted and ready to land.Wed, Jun 19, 6:15 AM

Closed by commit rCOMMa0954eecab3e: [identity] update change password RPCs to match whitepaper (authored by varun). · Explain WhyWed, Jun 19, 6:39 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMa0954eecab3e: [identity] update change password RPCs to match whitepaper.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

3 lines

CommRustModule.cpp

9 lines

_generated/

rustJSI-generated.cpp

native_rust_library/

src/

identity/

account_actions.rs

25 lines

3 lines

schema/

CommRustModuleSchema.js

3 lines

services/

identity/

src/

client_service.rs

95 lines

1 line

grpc_services/

authenticated.rs

61 lines

shared/

protos/

identity_auth.proto

17 lines

web/

protobufs/

identity-auth-structs.cjs

identity-auth-structs.cjs.flow

18 lines

Diff 41483

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...

native/native_rust_library/src/identity/account_actions.rs

Loading...

native/native_rust_library/src/lib.rs

Loading...

native/schema/CommRustModuleSchema.js

Loading...

services/identity/src/client_service.rs

Loading...

services/identity/src/constants.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...

shared/protos/identity_auth.proto

Loading...

web/protobufs/identity-auth-structs.cjs

Loading...

web/protobufs/identity-auth-structs.cjs.flow

Loading...