[nix] Update dev-shell.nix with comment on SystemConfiguration
ClosedPublic
Actions

Authored by will on Jan 17 2024, 11:12 AM.

Details

Reviewers

ashoat
varun

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM0107bf19c4e7: [nix] Update dev-shell.nix with comment on SystemConfiguration

Summary

The reqwest requires the SystemConfiguration which is not available in the MacOS linker.

This adds a reminder comment to our nix shell to remove the SystemConfiguration dependency when the reqwest issue is resolved:
https://github.com/seanmonstar/reqwest/issues/2006#issue-1952682498

Test Plan

Successfully ran nix develop

Diff Detail

Repository

rCOMM Comm

Branch

wyilio/add-reqwest-comment

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jan 17 2024, 11:12 AM

Owners added a reviewer: Restricted Owners Package.Jan 17 2024, 11:12 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 17 2024, 11:12 AM

will mentioned this in D10392: [services] [5/n] prefix search websocket server.Jan 17 2024, 11:13 AM

Harbormaster completed remote builds in B25842: Diff 35733.Jan 17 2024, 11:31 AM

will requested review of this revision.Jan 17 2024, 11:31 AM

ashoat accepted this revision.Jan 17 2024, 1:11 PM

This revision is now accepted and ready to land.Jan 17 2024, 1:11 PM

Closed by commit rCOMM0107bf19c4e7: [nix] Update dev-shell.nix with comment on SystemConfiguration (authored by will). · Explain WhyJan 18 2024, 9:11 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM0107bf19c4e7: [nix] Update dev-shell.nix with comment on SystemConfiguration.

Revision Contents
Changeset List

Path

Size

nix/

dev-shell.nix

1 line

Diff 35733

View Options

[nix] Update dev-shell.nix with comment on SystemConfigurationClosedPublicActions